10077 usr/src/uts/ Makefile changes for smatch

          --- old/usr/src/uts/intel/emlxs/Makefile
          +++ new/usr/src/uts/intel/emlxs/Makefile

   1    1  #
   2    2  # CDDL HEADER START
   3    3  #
   4    4  # The contents of this file are subject to the terms of the
   5    5  # Common Development and Distribution License (the "License").
   6    6  # You may not use this file except in compliance with the License.
   7    7  #
   8    8  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9  # or http://www.opensolaris.org/os/licensing.
  10   10  # See the License for the specific language governing permissions
  11   11  # and limitations under the License.
  12   12  #
  13   13  # When distributing Covered Code, include this CDDL HEADER in each
  14   14  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.

  15   15  # If applicable, add the following below this CDDL HEADER, with the
  16   16  # fields enclosed by brackets "[]" replaced with your own identifying
  17   17  # information: Portions Copyright [yyyy] [name of copyright owner]
  18   18  #
  19   19  # CDDL HEADER END
  20   20  #
  21   21  #
  22   22  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  23   23  # Use is subject to license terms.
  24   24  # Copyright (c) 2011 Bayard G. Bell. All rights reserved.
       25 +# Copyright (c) 2018, Joyent, Inc.
  25   26  #
  26   27  # This makefile drives the production of the emlxs driver kernel module.
  27   28  #
  28   29  # Path to the base of the uts directory tree (usually /usr/src/uts).
  29   30  #
  30   31  UTSBASE         = ../../
  31   32  COMMON_BASE     = ../../../common
  32   33  
  33   34  #
  34   35  #       Define the module and object file sets.

  35   36  #
  36   37  MODULE          = emlxs
  37   38  OBJECTS         = $(EMLXS_OBJS:%=$(OBJS_DIR)/%)
  38   39  LINTS           = $(EMLXS_OBJS:%.o=$(LINTS_DIR)/%.ln)
  39   40  ROOTMODULE      = $(ROOT_DRV_DIR)/$(MODULE)
  40   41  CONF_SRCDIR     = $(UTSBASE)/common/io/fibre-channel/fca/emlxs
  41   42  
  42   43  #
  43   44  #       Include common rules.
  44   45  #
  45   46  ARCHDIR         = intel
  46   47  include ../Makefile.$(ARCHDIR)
  47   48  
  48   49  #
  49   50  #       Define targets
  50   51  #
  51   52  ALL_TARGET      = $(BINARY) $(SRC_CONFILE)
  52   53  LINT_TARGET     = $(MODULE).lint
  53   54  INSTALL_TARGET  = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE)
  54   55  
  55   56  EMLXS_FLAGS             = -DEMLXS_I386
  56   57  EMLXS_FLAGS             += -DS11
  57   58  EMLXS_FLAGS             += -DVERSION=\"11\"
  58   59  EMLXS_FLAGS             += -DMACH=\"$(MACH)\"
  59   60  EMLXS_CFLAGS            = $(EMLXS_FLAGS)
  60   61  EMLXS_LFLAGS            = $(EMLXS_FLAGS)
  61   62  CFLAGS                  += $(EMLXS_CFLAGS) -DEMLXS_ARCH=\"$(CLASS)\"
  62   63  LINTTAGS                += $(EMLXS_LFLAGS) -DEMLXS_ARCH=\"$(CLASS)\"
  63   64  
  64   65  
  65   66  #
  66   67  #       Overrides and depends_on
  67   68  #
  68   69  INC_PATH        += -I$(ROOT)/usr/include
  69   70  INC_PATH        += -I$(UTSBASE)/common/sys
  70   71  INC_PATH        += -I$(COMMON_BASE)/bignum
  71   72  INC_PATH        += -I$(UTSBASE)/common/sys/fibre-channel
  72   73  INC_PATH        += -I$(UTSBASE)/common/sys/fibre-channel/fca
  73   74  INC_PATH        += -I$(UTSBASE)/common/sys/fibre-channel/fca/emlxs
  74   75  INC_PATH        += -I$(UTSBASE)/common/sys/fibre-channel/impl
  75   76  INC_PATH        += -I$(UTSBASE)/common/sys/fibre-channel/ulp
  76   77  
  77   78  #
  78   79  #       misc/fctl required because #ifdef MODSYM_LOAD code
  79   80  #       triggered by -DS11; uses DDI calls to load FCA symbols
  80   81  #
  81   82  LDFLAGS         += -dy -Nmisc/md5 -Nmisc/sha1
  82   83  LDFLAGS         += -Nmisc/bignum -Nmisc/fctl
  83   84  
  84   85  #
  85   86  # For now, disable these lint checks; maintainers should endeavor
  86   87  # to investigate and remove these for maximum lint coverage.
  87   88  #

  88   89  LINTTAGS        += -erroff=E_BAD_PTR_CAST_ALIGN
  89   90  LINTTAGS        += -erroff=E_STATIC_UNUSED
  90   91  LINTTAGS        += -erroff=E_ASSIGN_NARROW_CONV
  91   92  LINTTAGS        += -erroff=E_SUSPICIOUS_COMPARISON
  92   93  LINTTAGS        += -erroff=E_INCONS_VAL_TYPE_DECL2
  93   94  
  94   95  CERRWARN        += -_gcc=-Wno-parentheses
  95   96  CERRWARN        += -_gcc=-Wno-unused-label
  96   97  CERRWARN        += -_gcc=-Wno-uninitialized
  97   98  
       99 +SMOFF += indenting,deref_check,all_func_returns
      100 +
      101 +# seems definitely wrong
      102 +$(OBJS_DIR)/emlxs_fcf.o := SMOFF += logical_instead_of_bitwise
      103 +
  98  104  #
  99  105  #       Default build targets.
 100  106  #
 101  107  .KEEP_STATE:
 102  108  
 103  109  def:            $(DEF_DEPS)
 104  110  
 105  111  all:            $(ALL_DEPS)
 106  112  
 107  113  clean:          $(CLEAN_DEPS)

 108  114  
 109  115  clobber:        $(CLOBBER_DEPS)
 110  116  
 111  117  lint:           $(LINT_DEPS)
 112  118  
 113  119  modlintlib:     $(MODLINTLIB_DEPS)
 114  120  
 115  121  clean.lint:     $(CLEAN_LINT_DEPS)
 116  122  
 117  123  install:        $(INSTALL_DEPS)
 118  124  
 119  125  #
 120  126  #       Include common targets.
 121  127  #
 122  128  include ../Makefile.targ

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX