10063 basic support for smatch
10153 checkpaths shouldn't check packaging exceptions

          --- old/usr/src/tools/scripts/checkpaths.sh
          +++ new/usr/src/tools/scripts/checkpaths.sh

   1    1  #!/bin/ksh -p
   2    2  #
   3    3  # CDDL HEADER START
   4    4  #
   5    5  # The contents of this file are subject to the terms of the
   6    6  # Common Development and Distribution License (the "License").
   7    7  # You may not use this file except in compliance with the License.
   8    8  #
   9    9  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
  10   10  # or http://www.opensolaris.org/os/licensing.
  11   11  # See the License for the specific language governing permissions

  12   12  # and limitations under the License.
  13   13  #
  14   14  # When distributing Covered Code, include this CDDL HEADER in each
  15   15  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  16   16  # If applicable, add the following below this CDDL HEADER, with the
  17   17  # fields enclosed by brackets "[]" replaced with your own identifying
  18   18  # information: Portions Copyright [yyyy] [name of copyright owner]
  19   19  #
  20   20  # CDDL HEADER END
  21   21  #
  22      -
  23      -#
  24   22  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  25   23  # Use is subject to license terms.
  26   24  #
       25 +# Copyright (c) 2018, Joyent, Inc.
  27   26  
  28   27  # Quis custodiet ipsos custodies?
  29   28  
  30   29  if [ -z "$SRC" ]; then
  31   30          SRC=$CODEMGR_WS/usr/src
  32   31  fi
  33   32  
  34   33  if [ -z "$CODEMGR_WS" -o ! -d "$CODEMGR_WS" -o ! -d "$SRC" ]; then
  35   34          echo "$0: must be run from within a workspace."
  36   35          exit 1

  37   36  fi
  38   37  
  39   38  cd $CODEMGR_WS || exit 1
  40   39  
  41   40  # Use -b to tell this script to ignore derived (built) objects.
  42   41  if [ "$1" = "-b" ]; then
  43   42          b_flg=y
  44   43  fi
  45   44  
  46   45  # Not currently used; available for temporary workarounds.
  47   46  args="-k NEVER_CHECK"
  48   47  
  49   48  # We intentionally don't depend on $MACH here, and thus no $ROOT.  If
  50   49  # a proto area exists, then we use it.  This allows this script to be
  51   50  # run against gates (which should contain both SPARC and x86 proto
  52   51  # areas), build workspaces (which should contain just one proto area),
  53   52  # and unbuilt workspaces (which contain no proto areas).
  54   53  if [ "$b_flg" = y ]; then
  55   54          rootlist=
  56   55  elif [ $# -gt 0 ]; then
  57   56          rootlist=$*
  58   57  else
  59   58          rootlist="$CODEMGR_WS/proto/root_sparc $CODEMGR_WS/proto/root_i386"
  60   59  fi
  61   60  
  62   61  for ROOT in $rootlist
  63   62  do
  64   63          case "$ROOT" in
  65   64          *sparc|*sparc-nd)

  66   65                  arch=sparc
  67   66                  ;;
  68   67          *i386|*i386-nd)
  69   68                  arch=i386
  70   69                  ;;
  71   70          *)
  72   71                  echo "$ROOT has unknown architecture." >&2
  73   72                  exit 1
  74   73                  ;;
  75   74          esac
  76      -        if [ -d $ROOT ]; then
  77      -                #
  78      -                # This is the old-style packaging exception list, from
  79      -                # the svr4-specific usr/src/pkgdefs
  80      -                #
  81      -                [ -f $SRC/pkgdefs/etc/exception_list_$arch ] && \
  82      -                        validate_paths '-s/\s*'$arch'$//'  \
  83      -                            -e ^usr/include/ike/ -b $ROOT \
  84      -                            $args $SRC/pkgdefs/etc/exception_list_$arch
  85      -                #
  86      -                # These are the new-style packaging exception lists,
  87      -                # from the repository-wide exception_lists/ directory.
  88      -                #
  89      -                e="$CODEMGR_WS/exception_lists/packaging"
  90      -                for f in $e; do
  91      -                        if [ -f $f ]; then
  92      -                                nawk 'NF == 1 || /[     ]\+'$arch'$/ { print; }' \
  93      -                                    < $f | validate_paths -b $ROOT -n $f
  94      -                        fi
  95      -                done
  96      -        fi
  97   75  done
  98   76  
  99   77  # Two entries in the findunref exception_list deal with things created
 100   78  # by nightly.  Otherwise, this test could be run on an unmodifed (and
 101   79  # unbuilt) workspace.  We handle this by flagging the one that is
 102   80  # present only on a built workspace (./*.out) and the one that's
 103   81  # present only after a run of findunref (./*.ref) with ISUSED, and
 104   82  # disabling all checks of them.  The assumption is that the entries
 105   83  # marked with ISUSED are always known to be good, thus the Latin quote
 106   84  # at the top of the file.

 107   85  #
 108   86  # The exception_list is generated from whichever input files are appropriate
 109   87  # for this workspace, so checking it obviates the need to check the inputs.
 110   88  
 111   89  if [ -r $SRC/tools/findunref/exception_list ]; then
 112   90          validate_paths -k ISUSED -r -e '^\*' $SRC/tools/findunref/exception_list
 113   91  fi
 114   92  
 115   93  if [ -f $SRC/tools/opensolaris/license-list ]; then
 116   94          sed -e 's/$/.descrip/' < $SRC/tools/opensolaris/license-list | \
 117   95                  validate_paths -n SRC/tools/opensolaris/license-list
 118   96  fi
 119   97  
 120   98  validate_flg -f
 121   99  
 122  100  exit 0

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX