Code Review for illumos8485-2

Prepared by:Gary Mills (mills) on 2017-Jul-22 15:41 -0500 CDT
Workspace:/dpool/export/home/mills/Downloads/code/illumos-gate (at 21d124555691)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at d1151f9bab09)
Summary of changes: 144 lines changed: 24 ins; 83 del; 37 mod; 17992 unchg
Patch of changes: illumos8485-2.patch
Printable review: illumos8485-2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bnu/uuglist.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 3 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/bnu/uustat.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 4 del; 0 mod; 1593 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/talk/get_names.c 

8485 Remove set but unused variables in usr/src/cmd
6 lines changed: 1 ins; 5 del; 0 mod; 155 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/ipadm/ipadm.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 4 del; 0 mod; 2211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_dhcpv6.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 0 del; 2 mod; 1049 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_rpcsec.c 

8485 Remove set but unused variables in usr/src/cmd
9 lines changed: 1 ins; 2 del; 6 mod; 395 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/gss/gssd/gssdtest.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 2 del; 0 mod; 2180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/network-devices/common.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 0 del; 2 mod; 339 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/storage/addon-storage.c 

8485 Remove set but unused variables in usr/src/cmd
9 lines changed: 1 ins; 8 del; 0 mod; 441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/ipfcomp.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 4 del; 0 mod; 1373 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ipf/tools/ippool.c 

8485 Remove set but unused variables in usr/src/cmd
14 lines changed: 1 ins; 10 del; 3 mod; 895 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/krb5/ldap_util/kdb5_ldap_list.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 0 ins; 5 del; 0 mod; 284 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/krb5/ldap_util/kdb5_ldap_realm.c 

8485 Remove set but unused variables in usr/src/cmd
20 lines changed: 1 ins; 5 del; 14 mod; 2661 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ldap/common/fileurl.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 2 del; 0 mod; 515 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/lp/lib/papi/ppd.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 4 del; 0 mod; 160 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mail/copylet.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 4 del; 0 mod; 398 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/print/bsd-sysv-commands/disable.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 2 del; 0 mod; 161 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/print/bsd-sysv-commands/lpr.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 4 del; 0 mod; 272 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/refer/glue4.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 3 del; 1 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/refer/hunt7.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 2 del; 2 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sh/xec.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 1 del; 1 mod; 538 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svr4pkg/pkgremove/special.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 0 del; 2 mod; 708 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/troff/nroff.d/n6.c 

8485 Remove set but unused variables in usr/src/cmd
3 lines changed: 1 ins; 1 del; 1 mod; 504 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/volcheck/volcheck.c 

8485 Remove set but unused variables in usr/src/cmd
7 lines changed: 1 ins; 6 del; 0 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ypcmd/ypserv.c 

8485 Remove set but unused variables in usr/src/cmd
5 lines changed: 1 ins; 2 del; 2 mod; 639 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.