Code Review for illumos5196-2

Prepared by:Gary Mills (mills) on 2014-Oct-07 15:48 -0500 CDT
Workspace:/dpool/export/home/mills/Downloads/code/illumos-gate (at d7668377711f)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at dcf050af29bc)
Summary of changes: 138 lines changed: 66 ins; 27 del; 45 mod; 8768 unchg
Patch of changes: illumos5196-2.patch
Printable review: illumos5196-2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

5196 The cw wrapper restricts gcc to -O2
44 lines changed: 27 ins; 4 del; 13 mod; 1151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/test/tst/Makefile.com

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dtrace/test/tst/common/Makefile

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com

5196 The cw wrapper restricts gcc to -O2
4 lines changed: 1 ins; 0 del; 3 mod; 1375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparcv9/Makefile.com

5196 The cw wrapper restricts gcc to -O2
3 lines changed: 1 ins; 0 del; 2 mod; 1295 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsum/Makefile.com

5196 The cw wrapper restricts gcc to -O2
8 lines changed: 4 ins; 0 del; 4 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/libsoftcrypto/amd64/Makefile

5196 The cw wrapper restricts gcc to -O2
4 lines changed: 3 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pkcs11/libsoftcrypto/capabilities/sun4v/Makefile.com

5196 The cw wrapper restricts gcc to -O2
4 lines changed: 3 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.c

5196 The cw wrapper restricts gcc to -O2
25 lines changed: 2 ins; 22 del; 1 mod; 1890 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/arcfour/Makefile

5196 The cw wrapper restricts gcc to -O2
4 lines changed: 3 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/bignum/Makefile.64

5196 The cw wrapper restricts gcc to -O2
3 lines changed: 2 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/myri10ge/Makefile

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ntxn/Makefile

5196 The cw wrapper restricts gcc to -O2
5 lines changed: 3 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/xge/Makefile

5196 The cw wrapper restricts gcc to -O2
5 lines changed: 3 ins; 0 del; 2 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/Makefile.sparc

5196 The cw wrapper restricts gcc to -O2
4 lines changed: 1 ins; 1 del; 2 mod; 500 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/dld/Makefile

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/dls/Makefile

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/mac/Makefile

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/myri10ge/Makefile

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/xge/Makefile

5196 The cw wrapper restricts gcc to -O2
5 lines changed: 3 ins; 0 del; 2 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/Makefile.sun4u

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 475 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/Makefile.sun4v

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/arcfour/Makefile

5196 The cw wrapper restricts gcc to -O2
2 lines changed: 1 ins; 0 del; 1 mod; 105 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.