Code Review for illumos4211-1

Prepared by:Gary Mills (mills) on 2013-Oct-28 12:46 -0500 CDT
Workspace:/home/mills/Downloads/code/illumos-gate (at b33cf1e85b7d)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 746f551ddc19)
Summary of changes: 137 lines changed: 88 ins; 18 del; 31 mod; 7514 unchg
Patch of changes: illumos4211-1.patch
Printable review: illumos4211-1.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/logger/logger.c

4211 Some syslog facility names and symbols are missing
3232 syslogd shouldn't sync after each LOG_KERN line
1762 Syslogd man page: missing reference.
14 lines changed: 6 ins; 1 del; 7 mod; 356 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/syslogd/syslogd.c

4211 Some syslog facility names and symbols are missing
3232 syslogd shouldn't sync after each LOG_KERN line
1762 Syslogd man page: missing reference.
47 lines changed: 25 ins; 11 del; 11 mod; 5571 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/syslogd.1m

4211 Some syslog facility names and symbols are missing
3232 syslogd shouldn't sync after each LOG_KERN line
1762 Syslogd man page: missing reference.
5 lines changed: 1 ins; 0 del; 4 mod; 372 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/syslog.conf.4

4211 Some syslog facility names and symbols are missing
3232 syslogd shouldn't sync after each LOG_KERN line
1762 Syslogd man page: missing reference.
59 lines changed: 49 ins; 3 del; 7 mod; 365 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/logsubr.c

4211 Some syslog facility names and symbols are missing
3232 syslogd shouldn't sync after each LOG_KERN line
1762 Syslogd man page: missing reference.
3 lines changed: 1 ins; 0 del; 2 mod; 762 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/syslog.h

4211 Some syslog facility names and symbols are missing
3232 syslogd shouldn't sync after each LOG_KERN line
1762 Syslogd man page: missing reference.
9 lines changed: 6 ins; 3 del; 0 mod; 88 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.