Code Review for illumos1097-6

Prepared by:Gary Mills <gary_mills@fastmail.fm> on 2013-Jan-28 14:19 -0600 CST
Workspace:/dpool/export/home/mills/Downloads/code/illumos-oct (at 899d8b1fe0dc)}
Compare against: ssh://anonhg@hg.illumos.org/illumos-gate (at 93ee8890b568)
Summary of changes: 1546 lines changed: 1286 ins; 64 del; 196 mod; 1653 unchg
Patch of changes: illumos1097-6.patch
Printable review: illumos1097-6.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ssh/include/config.h

1097 glob(3c) needs to support non-POSIX options
3341 The sftp command should use the native glob()
3 lines changed: 3 ins; 0 del; 0 mod; 982 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/ssh/include/unwanted-glob.h (renamed from usr/src/cmd/ssh/include/glob.h)

1097 glob(3c) needs to support non-POSIX options
3341 The sftp command should use the native glob()
0 lines changed: 0 ins; 0 del; 0 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/glob.h

1097 glob(3c) needs to support non-POSIX options
3341 The sftp command should use the native glob()
75 lines changed: 66 ins; 2 del; 7 mod; 75 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/regex/THIRDPARTYLICENSE

1097 glob(3c) needs to support non-POSIX options
3341 The sftp command should use the native glob()
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/regex/THIRDPARTYLICENSE.descrip

1097 glob(3c) needs to support non-POSIX options
3341 The sftp command should use the native glob()
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/regex/glob.c

1097 glob(3c) needs to support non-POSIX options
3341 The sftp command should use the native glob()
1198 lines changed: 983 ins; 58 del; 157 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/glob.3c

1097 glob(3c) needs to support non-POSIX options
3341 The sftp command should use the native glob()
232 lines changed: 196 ins; 4 del; 32 mod; 400 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.