Code Review for illumos-extra

Prepared by:Joshua M. Clulow (jclulow) on 2013-Oct-07 21:46 +0000 UTC
Workspace:/ws/illumos-extra (at 1f4ad78c6985)
Compare against: 1f4ad78^ (at 13fada3272ff)
Summary of changes: 28 lines changed: 2 ins; 13 del; 13 mod; 211 unchg
Patch of changes: illumos-extra.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw cpp/Makefile

cpp: don't handroll an incorrect strtoul(3c), use the one in libc
The previous implementation would parse 0x7ff as 0x755 (etc).
2 lines changed: 2 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw cpp/yylex.c

cpp: don't handroll an incorrect strtoul(3c), use the one in libc
The previous implementation would parse 0x7ff as 0x755 (etc).
26 lines changed: 0 ins; 13 del; 13 mod; 139 unchg

This code review page was prepared using /ws/dplat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.