Prepared by: | Joshua M. Clulow (jclulow) on 2013-Oct-07 21:45 +0000 UTC |
---|---|
Workspace: | /ws/illumos-extra (at ec11ba8cbce5) |
Compare against: | ec11ba8^ (at 4b0bdc97b3cb) |
Summary of changes: | 5 lines changed: 1 ins; 1 del; 3 mod; 1567 unchg |
Patch of changes: | illumos-extra.patch |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw cpp/cpp.c
cpp: only consider macro calls unterminated if they ever began We should only error about an unterminated macro parameter list if a parameter list was begun. If we never even seen the _first_ parenthesis, there is nothing to terminate. Previously, we would set the parenthesis level to -1 when expecting parameters (such that when we saw the opening paren it became the 0th level), but when checking for unterminated expansion we would strictly compare to 0, and thus flag a macro which needed parameters but lacked them as having an unterminated parameter list.5 lines changed: 1 ins; 1 del; 3 mod; 1567 unchg
This code review page was prepared using /ws/dplat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.