Code Review for illumos

Prepared by:Joshua M. Clulow (jclulow) on 2013-Jul-20 04:30 +0000 UTC
Workspace:/ws/dplat/projects/illumos (at 9bf4da9285d2)
Compare against: origin/master (git://github.com/joyent/illumos-joyent.git at 5c0519e0a200)
Summary of changes: 1821 lines changed: 730 ins; 1060 del; 31 mod; 53314 unchg
Patch of changes: illumos.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw manifest

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
1 line changed: 0 ins; 0 del; 1 mod; 17533 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/Makefile.files

OS-2366 ddi_periodic_add(9F) is entirely rubbish
2 lines changed: 2 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/ddi_periodic.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/common/modules/genunix/ddi_periodic.h

OS-2366 ddi_periodic_add(9F) is entirely rubbish
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/genunix.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
5 lines changed: 4 ins; 0 del; 1 mod; 4587 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
1 line changed: 0 ins; 0 del; 1 mod; 2137 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE MORE)
3 lines changed: 2 ins; 0 del; 1 mod; 2058 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/clock.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish
13 lines changed: 0 ins; 10 del; 3 mod; 2662 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/damap.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
1 line changed: 0 ins; 0 del; 1 mod; 1730 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/ddi_periodic.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
493 lines changed: 493 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch --- usr/src/uts/common/os/ddi_timer.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish
901 lines changed: 0 ins; 901 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/main.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish
6 lines changed: 4 ins; 0 del; 2 mod; 648 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/sunddi.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
1 line changed: 0 ins; 0 del; 1 mod; 10070 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/Makefile

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
1 line changed: 0 ins; 0 del; 1 mod; 1400 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/ddi_periodic.h

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch --- usr/src/uts/common/sys/ddi_timer.h

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish
147 lines changed: 0 ins; 147 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/syscall/uadmin.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
8 lines changed: 7 ins; 0 del; 1 mod; 460 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/apix/apix.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
17 lines changed: 11 ins; 0 del; 6 mod; 2550 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pcplusmp/apic.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
21 lines changed: 16 ins; 0 del; 5 mod; 1381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pcplusmp/apic_common.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish
4 lines changed: 3 ins; 0 del; 1 mod; 1724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/startup.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish
6 lines changed: 1 ins; 2 del; 3 mod; 3231 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/apic_common.h

OS-2366 ddi_periodic_add(9F) is entirely rubbish
5 lines changed: 4 ins; 0 del; 1 mod; 199 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/intr.c

OS-2366 ddi_periodic_add(9F) is entirely rubbish (MORE)
OS-2366 ddi_periodic_add(9F) is entirely rubbish
6 lines changed: 4 ins; 0 del; 2 mod; 867 unchg

This code review page was prepared using /ws/dplat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.