Code Review for illumos

Prepared by:Joshua M. Clulow (jclulow) on 2013-Mar-14 21:03 +0000 UTC
Workspace:/ws/dplat/projects/illumos (at 0d62916038b8)
Compare against: origin/master (git@github.com:joyent/illumos-joyent.git at eddec1f8e073)
Summary of changes: 444 lines changed: 386 ins; 40 del; 18 mod; 37923 unchg
Patch of changes: illumos.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw manifest

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
1 line changed: 1 ins; 0 del; 0 mod; 17531 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_hc.h

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_xml.c

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
19 lines changed: 2 ins; 13 del; 4 mod; 2130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/common/Makefile

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
1 line changed: 1 ins; 0 del; 0 mod; 39 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/modules/common/fac_prov_mptsas/Makefile

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/fm/topo/modules/common/fac_prov_mptsas/fac_prov_mptsas.c

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
244 lines changed: 244 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas.c

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
118 lines changed: 77 ins; 27 del; 14 mod; 16253 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/scsi/adapters/mpt_sas/mptsas_ioctl.h

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
21 lines changed: 21 ins; 0 del; 0 mod; 336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/scsi/adapters/mpt_sas/mptsas_var.h

OS-1997 mpt_sas: expose LED controls to libtopo
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 1471 unchg

This code review page was prepared using /ws/plat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.