Code Review for illumos

Prepared by:Joshua M. Clulow (jclulow) on 2013-Jan-30 07:34 +0000 UTC
Workspace:/ws/plat/projects/illumos (at a1fe81de3534)
Compare against: origin/master (git://github.com/joyent/illumos-joyent at 16c40b242635)
Summary of changes: 469 lines changed: 461 ins; 0 del; 8 mod; 2906 unchg
Patch of changes: illumos.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/asru.c

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/error.c

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/fault.c

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 289 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/fmdump.c

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
18 lines changed: 11 ins; 0 del; 7 mod; 1494 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/fmdump.h

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/info.c

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
4 lines changed: 4 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/nvlrender.c

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
17 lines changed: 17 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/Makefile.com

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
10 lines changed: 9 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/libnvpair.h

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/mapfile-vers

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 2 ins; 0 del; 0 mod; 289 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libnvpair/nvpair_json.c

OS-1840 fmdump shall emit JSON
Reviewed by: Robert Mustacchi <rm@joyent.com>
400 lines changed: 400 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /ws/plat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.