Code Review for illumos

Prepared by:Joshua M. Clulow (jclulow) on 2013-Jan-29 00:40 +0000 UTC
Workspace:/ws/plat/projects/illumos (at 7662d3a8db7e)
Compare against: origin/master (git://github.com/joyent/illumos-joyent at a0dfeda4da9e)
Summary of changes: 430 lines changed: 421 ins; 1 del; 8 mod; 2984 unchg
Patch of changes: illumos.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/Makefile.com

OS-1840 fmdump shall emit JSON (use library)
OS-1840 fmdump shall emit JSON
1 line changed: 1 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/asru.c

OS-1840 fmdump shall emit JSON
4 lines changed: 4 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/error.c

OS-1840 fmdump shall emit JSON
4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/fault.c

OS-1840 fmdump shall emit JSON
6 lines changed: 5 ins; 1 del; 0 mod; 288 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/fmdump.c

OS-1840 fmdump shall emit JSON
18 lines changed: 11 ins; 0 del; 7 mod; 1494 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/fmdump.h

OS-1840 fmdump shall emit JSON
4 lines changed: 4 ins; 0 del; 0 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/info.c

OS-1840 fmdump shall emit JSON
4 lines changed: 4 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmdump/common/nvlrender.c

OS-1840 fmdump shall emit JSON (copyright fixes)
OS-1840 fmdump shall emit JSON (use library)
14 lines changed: 14 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/Makefile.com

OS-1840 fmdump shall emit JSON (copyright fixes)
OS-1840 fmdump shall emit JSON (nvlist_print_json)
4 lines changed: 3 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/libnvpair.h

OS-1840 fmdump shall emit JSON (copyright fixes)
OS-1840 fmdump shall emit JSON (nvlist_print_json fixes)
2 lines changed: 2 ins; 0 del; 0 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnvpair/mapfile-vers

OS-1840 fmdump shall emit JSON (copyright fixes)
OS-1840 fmdump shall emit JSON (nvlist_print_json)
2 lines changed: 2 ins; 0 del; 0 mod; 289 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libnvpair/nvpair_json.c

OS-1840 fmdump shall emit JSON (fix u0000 escape)
OS-1840 fmdump shall emit JSON (nvlist_print_json fixes)
OS-1840 fmdump shall emit JSON (nvlist_print_json)
367 lines changed: 367 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /ws/plat/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.