Print this page
OS-1571 Placate gcc -Wparentheses
Reviewed by: Robert Mustacchi <rm@joyent.com>

@@ -2665,13 +2665,13 @@
                  * by the same amount.  But we want uiop->uio_offset to change
                  * in increments of LXPR_SDSIZE, which is different from the
                  * number of bytes being returned to the user.  So we set
                  * uiop->uio_offset separately, ignoring what uiomove() does.
                  */
-                if (error = uiomove((caddr_t)dirent, reclen, UIO_READ, uiop)) {
+                if ((error = uiomove((caddr_t)dirent, reclen, UIO_READ,
+                    uiop)) != 0)
                         return (error);
-                }
 
                 uiop->uio_offset = uoffset + LXPR_SDSIZE;
         }
 
         /* Have run out of space, but could have just done last table entry */

@@ -2803,11 +2803,12 @@
                  * in increments of LXPR_SDSIZE, which is different from the
                  * number of bytes being returned to the user.  So we set
                  * uiop->uio_offset separately, in the increment of this for
                  * the loop, ignoring what uiomove() does.
                  */
-                if (error = uiomove((caddr_t)dirent, reclen, UIO_READ, uiop))
+                if ((error = uiomove((caddr_t)dirent, reclen, UIO_READ,
+                    uiop)) != 0)
                         return (error);
 next:
                 uiop->uio_offset = uoffset + LXPR_SDSIZE;
         }
 

@@ -2935,11 +2936,12 @@
                         if (uresid == oresid)
                                 error = EINVAL;
                         goto out;
                 }
 
-                if (error = uiomove((caddr_t)dirent, reclen, UIO_READ, uiop))
+                if ((error = uiomove((caddr_t)dirent, reclen, UIO_READ,
+                    uiop)) != 0)
                         goto out;
         }
 
         if (eofp != NULL) {
                 *eofp =