Code Review for illumos-gate

Prepared by:Joshua M. Clulow (jclulow) on 2013-Jan-18 13:59 -0800 PST
Workspace:/ws/jclulow/illumos-gate (at 6d1342eb9c7b)
Compare against: HEAD^ (at 33c41f2b7f5e)
Summary of changes: 531 lines changed: 427 ins; 28 del; 76 mod; 34319 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/tail/extern.h

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
14 lines changed: 14 ins; 0 del; 0 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/tail/forward.c

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
99 lines changed: 93 ins; 2 del; 4 mod; 363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/tail/tests/tailtests.sh

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
294 lines changed: 239 ins; 13 del; 42 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/tail.1

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
22 lines changed: 14 ins; 0 del; 8 mod; 288 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/port_associate.3c

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
18 lines changed: 3 ins; 0 del; 15 mod; 416 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs3_vnops.c

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
15 lines changed: 11 ins; 4 del; 0 mod; 6735 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_vnops.c

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
15 lines changed: 11 ins; 3 del; 1 mod; 15982 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_vnops.c

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
16 lines changed: 12 ins; 4 del; 0 mod; 5080 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/portfs/port_fop.c

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
11 lines changed: 8 ins; 0 del; 3 mod; 2341 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/tmpfs/tmp_vnops.c

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
9 lines changed: 7 ins; 0 del; 2 mod; 2441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/port.h

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
7 lines changed: 5 ins; 2 del; 0 mod; 140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/port_impl.h

3484 enhance and document tail follow support
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
11 lines changed: 10 ins; 0 del; 1 mod; 378 unchg

This code review page was prepared using /ws/jclulow/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.