Prepared by: | Joshua M. Clulow (jclulow) on 2012-Dec-16 13:00 -0800 PST |
---|---|
Workspace: | /ws/jclulow/illumos-gate (at 65e2feefe0fb) |
Compare against: | origin/master (git://github.com/illumos/illumos-gate at 72025881906f) |
Summary of changes: | 961 lines changed: 502 ins; 318 del; 141 mod; 7170 unchg |
Patch of changes: | illumos-gate.patch |
Printable review: | illumos-gate.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_main.c
style fixes comments; lint unbreak dis move fixed-size determination mostly into libdisasm take to dis and libdisasm with an axe; does not yet compile29 lines changed: 19 ins; 5 del; 5 mod; 710 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_target.c
remove crap I didnt end up using take to dis and libdisasm with an axe; does not yet compile2 lines changed: 0 ins; 2 del; 0 mod; 958 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_target.h
remove more unused crap take to dis and libdisasm with an axe; does not yet compile2 lines changed: 0 ins; 2 del; 0 mod; 92 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/Makefile.com
need includes from common/dis/i386 on sparc too reorder some things in Makefile.com style fixes only include native support in standalone library rename instr.c take to dis and libdisasm with an axe; does not yet compile45 lines changed: 19 ins; 11 del; 15 mod; 111 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/Makefile.targ
only include native support in standalone library5 lines changed: 0 ins; 5 del; 0 mod; 92 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/amd64/Makefile
style fixes sparc instr.c is C993 lines changed: 2 ins; 1 del; 0 mod; 36 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_i386.c
take to dis and libdisasm with an axe; does not yet compile249 lines changed: 249 ins; 0 del; 0 mod; 0 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc.c (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc.c)
BE_32 wont work in libstand mode take to dis and libdisasm with an axe; does not yet compile97 lines changed: 41 ins; 28 del; 28 mod; 283 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc.h (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc.h)
style fixes take to dis and libdisasm with an axe; does not yet compile13 lines changed: 0 ins; 8 del; 5 mod; 96 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_fmt.c (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc_fmt.c)
style fixes comments; lint take to dis and libdisasm with an axe; does not yet compile98 lines changed: 20 ins; 0 del; 78 mod; 2676 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_fmt.h (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc_fmt.h)
style fixes take to dis and libdisasm with an axe; does not yet compile2 lines changed: 0 ins; 2 del; 0 mod; 122 unchg
------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_instr.c (renamed from usr/src/lib/libdisasm/sparc/instr.c)
rename instr.c0 lines changed: 0 ins; 0 del; 0 mod; 1701 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.c
style fixes only include native support in standalone library take to dis and libdisasm with an axe; does not yet compile122 lines changed: 120 ins; 2 del; 0 mod; 90 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.h
fixup dis_min_instrlen take to dis and libdisasm with an axe; does not yet compile19 lines changed: 7 ins; 2 del; 10 mod; 70 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm_impl.h
fixup dis_min_instrlen take to dis and libdisasm with an axe; does not yet compile24 lines changed: 22 ins; 2 del; 0 mod; 43 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/mapfile-vers
move fixed-size determination mostly into libdisasm1 line changed: 1 ins; 0 del; 0 mod; 55 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/i386/Makefile
style fixes sparc instr.c is C993 lines changed: 2 ins; 1 del; 0 mod; 35 unchg
------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libdisasm/i386/dis_i386.c (deleted)
take to dis and libdisasm with an axe; does not yet compile247 lines changed: 0 ins; 247 del; 0 mod; 0 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.