Print this page
9644 Double-free in crypto tests on failure
Reviewed by: Dan McDonald <danmcd@joyent.com>
Reviewed by: Mike Zeller <mike.zeller@joyent.com>

@@ -100,11 +100,10 @@
         rv = pkcs11_str2mech(op->mechname, &op->mech);
         if (rv != CKR_OK) {
                 cryptotest_error("get_mech_info", rv);
                 (void) fprintf(stderr, "failed to resolve mechanism name %s\n",
                     op->mechname);
-                (void) cryptotest_close(op);
                 return (CTEST_NAME_RESOLVE_FAILED);
         }
         return (rv);
 }
 

@@ -117,11 +116,10 @@
         if (rv != CKR_OK) {
                 cryptotest_error("get_hsession_by_mech", rv);
                 (void) fprintf(stderr,
                     "could not find provider for mechanism %lu\n",
                     op->mech);
-                (void) cryptotest_close(op);
                 return (CTEST_MECH_NO_PROVIDER);
         }
         return (rv);
 }