Code Review for full

Prepared by:Jason King on 2018-Jun-05 20:44 -0500 CDT
Workspace:/export/home/jason/illumos-gate (at 549e767fe28d)
Compare against: /export/home/jason/illumos-gate (explicit revision 8dff7262702a)
Summary of changes: 47698 lines changed: 47477 ins; 137 del; 84 mod; 10506 unchg
Patch of changes: full.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/packaging

Rich's feedback
6375 Add native name demangling support
2 lines changed: 2 ins; 0 del; 0 mod; 1018 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/Makefile

Rich's feedback
6375 Add native name demangling support
3 lines changed: 2 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_util.c

Rich's feedback
Address Robert's feedback
6375 Add native name demangling support
51 lines changed: 3 ins; 39 del; 9 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/Makefile.mdb

Rich's feedback
6375 Add native name demangling support
2 lines changed: 2 ins; 0 del; 0 mod; 208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/kmdb/kmdb_demangle.c

6375 Add native name demangling support
5 lines changed: 2 ins; 2 del; 1 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_demangle.c

cleanup
Rich's feedback
Address Robert's feedback
6375 Add native name demangling support
116 lines changed: 39 ins; 47 del; 30 mod; 275 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_demangle.h

Rich's feedback
6375 Add native name demangling support
9 lines changed: 3 ins; 4 del; 2 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/dump/common/dump.c

cleanup
libconv
22 lines changed: 10 ins; 6 del; 6 mod; 2119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/gprof/common/printgprof.c

cleanup
libconv
32 lines changed: 12 ins; 7 del; 13 mod; 1038 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/Makefile.com

cleanup
9 lines changed: 9 ins; 0 del; 0 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/demangle.c

libconv
36 lines changed: 0 ins; 25 del; 11 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/demangle.msg

libconv
3 lines changed: 0 ins; 0 del; 3 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/lintsup.c

cleanup
2 lines changed: 1 ins; 1 del; 0 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/liblddbg/common/util.c

libconv
25 lines changed: 21 ins; 0 del; 4 mod; 353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/nm/common/nm.c

libconv
11 lines changed: 5 ins; 4 del; 2 mod; 1506 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/prof/common/prof.c

libconv
5 lines changed: 2 ins; 2 del; 1 mod; 1368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/prof/common/profv.c

libconv
3 lines changed: 2 ins; 0 del; 1 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

Rich's feedback
6375 Add native name demangling support
3 lines changed: 3 ins; 0 del; 0 mod; 727 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/Makefile

Rich's feedback
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/Makefile.com

Rich's feedback
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/THIRDPARTYLICENSE

Rich's feedback
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/THIRDPARTYLICENSE.descrip

Rich's feedback
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/amd64/Makefile

Rich's feedback
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/cxx.c

Rich's feedback
4213 lines changed: 4213 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/cxx.h

Rich's feedback
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/cxx_util.c

Rich's feedback
600 lines changed: 600 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/demangle-sys.h

Rich's feedback
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/demangle.c

Rich's feedback
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/demangle_int.h

Rich's feedback
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/llib-ldemangle-sys

Rich's feedback
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/mapfile-vers

Rich's feedback
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/str.c

Rich's feedback
313 lines changed: 313 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/str.h

Rich's feedback
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/common/util.c

Rich's feedback
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/i386/Makefile

Rich's feedback
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/sparc/Makefile

Rich's feedback
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdemangle/sparcv9/Makefile

Rich's feedback
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-library-demangle.mf

cleanup
Rich's feedback
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-utiltest.mf

cleanup
6375 Add native name demangling support
7 lines changed: 7 ins; 0 del; 0 mod; 282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/runfiles/default.run

6375 Add native name demangling support
3 lines changed: 3 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/Makefile

6375 Add native name demangling support
2 lines changed: 2 ins; 0 del; 0 mod; 20 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/demangle/Makefile

Rich's feedback
6375 Add native name demangling support
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/demangle/afl-fast.c

Rich's feedback
6375 Add native name demangling support
2955 lines changed: 2955 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/demangle/gcc-libstdc++.c

Rich's feedback
6375 Add native name demangling support
8670 lines changed: 8670 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/demangle/llvm-stdcxxabi.c

Rich's feedback
Address Robert's feedback
6375 Add native name demangling support
29733 lines changed: 29733 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.