Code Review for robert

Prepared by:Jason King on 2018-Feb-27 22:58 -0600 CST
Workspace:/export/home/jason/illumos-gate (at cd2654fbce77)
Compare against: /export/home/jason/illumos-gate (explicit revision 3bac8f6795c3)
Summary of changes: 345 lines changed: 48 ins; 69 del; 228 mod; 35413 unchg
Patch of changes: robert.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_util.c

Address Robert's feedback
5 lines changed: 5 ins; 0 del; 0 mod; 107 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_demangle.c

Address Robert's feedback
16 lines changed: 6 ins; 6 del; 4 mod; 322 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/Makefile

Address Robert's feedback
39 lines changed: 5 ins; 23 del; 11 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/Makefile.com

Address Robert's feedback
25 lines changed: 3 ins; 14 del; 8 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/common/cxx.c (renamed and modified from usr/src/lib/libsysdemangle/common/cpp.c)

Address Robert's feedback
203 lines changed: 10 ins; 18 del; 175 mod; 4027 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/common/cxx.h (renamed and modified from usr/src/lib/libsysdemangle/common/cpp.h)

Address Robert's feedback
2 lines changed: 0 ins; 0 del; 2 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/common/cxx_util.c (renamed and modified from usr/src/lib/libsysdemangle/common/cpp_util.c)

Address Robert's feedback
22 lines changed: 0 ins; 3 del; 19 mod; 581 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/common/str.c

Address Robert's feedback
16 lines changed: 14 ins; 0 del; 2 mod; 297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/common/str.h

Address Robert's feedback
1 line changed: 0 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/common/sysdemangle.c

Address Robert's feedback
8 lines changed: 2 ins; 4 del; 2 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysdemangle/common/util.c

Address Robert's feedback
4 lines changed: 0 ins; 1 del; 3 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/demangle/llvm-stdcxxabi.c

Address Robert's feedback
4 lines changed: 3 ins; 0 del; 1 mod; 29729 unchg

This code review page was prepared using /export/home/jason/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.