Code Review for smbcl-mmap

Prepared by:Gordon Ross (gwr) on 2018-Mar-04 06:09 -0500 EST
Workspace:/tank/ws/smbcl-mmap (at f3d7a4f7dc3d)
Compare against: /tank/ws/smbcl-mmap (explicit revision ff1e230c4ffc)
Summary of changes: 3084 lines changed: 2268 ins; 356 del; 460 mod; 7000 unchg
Patch of changes: smbcl-mmap.patch
Printable review: smbcl-mmap.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/mount_smbfs.1m
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

Convert mount_smbfs.1m to mdoc
534 lines changed: 41 ins; 129 del; 364 mod; 37 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs.h

5404 smbfs needs mmap support
Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
1 line changed: 1 ins; 0 del; 0 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs_client.c

Kill flags arg in smbfs_purge_caches
Lots of comment cleanup
5404 smbfs needs mmap support
Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
180 lines changed: 134 ins; 22 del; 24 mod; 696 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs_node.c

Lots of comment cleanup
5 lines changed: 0 ins; 5 del; 0 mod; 245 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs_node.h

5404 smbfs needs mmap support
Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
3 lines changed: 2 ins; 0 del; 1 mod; 322 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs_subr.h

Implement ioctl _FIODIRECTIO
Kill flags arg in smbfs_purge_caches
5404 smbfs needs mmap support
Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
11 lines changed: 10 ins; 1 del; 0 mod; 312 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs_subr2.c

cstyle
Implement ioctl _FIODIRECTIO
Lots of comment cleanup
5404 smbfs needs mmap support
Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
173 lines changed: 139 ins; 11 del; 23 mod; 1179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs_vfsops.c

5404 smbfs needs mmap support
Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
20 lines changed: 11 ins; 4 del; 5 mod; 1030 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbclnt/smbfs/smbfs_vnops.c

cstyle
Fix missing logic for ESTALE and NFS_EOF
Implement ioctl _FIODIRECTIO
Kill flags arg in smbfs_purge_caches
Lots of comment cleanup
5404 smbfs needs mmap support
Portions contributed by: Gordon Ross <gordon.w.ross@gmail.com>
2157 lines changed: 1930 ins; 184 del; 43 mod; 2995 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.