Code Review for 07

Prepared by:Gordon Ross (gwr) on 2018-Mar-18 01:13 -0400 EDT
Workspace:/tank/ws/smbcl-rpc (explicit head at 1cf913d7b19e)
Compare against: previous revision (at 9d405ccc57f8)
Summary of changes: 1304 lines changed: 842 ins; 430 del; 32 mod; 1076 unchg
Patch of changes: 07.patch
Printable review: 07.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/Makefile

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
21 lines changed: 13 ins; 4 del; 4 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/common.h

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
11 lines changed: 9 ins; 0 del; 2 mod; 67 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/info.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
212 lines changed: 212 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/shares_rap.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/shares_rpc.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/smbutil.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
4 lines changed: 4 ins; 0 del; 0 mod; 207 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1.ndl

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
177 lines changed: 177 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1_clnt.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1_clnt.h

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/view.c

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
68 lines changed: 16 ins; 26 del; 26 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsmbfs/Makefile.com

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 0 ins; 1 del; 0 mod; 137 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libsmbfs/netsmb/smb_netshareenum.h (deleted)

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
18 lines changed: 0 ins; 18 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsmbfs/smb/llib-lsmbfs

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 0 ins; 1 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsmbfs/smb/mapfile-vers

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 0 ins; 1 del; 0 mod; 169 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libsmbfs/smb/netshareenum.c (deleted)

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
378 lines changed: 0 ins; 378 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-file-system-smb.mf

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 0 ins; 1 del; 0 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-file-system-smb.mf

3328 smbutil view does't work with Win2008 and later
requires 1575 untangle libmlrpc ...
1 line changed: 1 ins; 0 del; 0 mod; 116 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.