Code Review for illumos-iconv

Prepared by:Gordon Ross <gwr@nexenta.com> on 2011-May-28 21:32 -0400 EDT
Workspace:/tank/ws/illumos-iconv (at d95c935089e1)
Compare against: /tank/ws/illumos-clone (at 43bfdefd2c41)
Summary of changes: 1862 lines changed: 1862 ins; 0 del; 0 mod; 0 unchg
Patch of changes: illumos-iconv.patch
Printable review: illumos-iconv.pdf
some test data: test

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/iconv/Makefile

30 Need iconv
74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/iconv/charmap.c

30 Need iconv
552 lines changed: 552 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/iconv/charmap.h

30 Need iconv
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/iconv/iconv.c

30 Need iconv
295 lines changed: 295 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/iconv/iconv_list.sh

30 Need iconv
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/iconv/parser.y

30 Need iconv
114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/iconv/scanner.c

30 Need iconv
678 lines changed: 678 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.