Code Review for illumos-gfx

Prepared by:Gordon Ross (gwr) on 2017-May-28 15:47 -0400 EDT
Workspace:/tank/ws/illumos-gfx (at 5257036268d1)
Compare against: /tank/ws/illumos-gfx (explicit revision 732c12d3fdba)
Summary of changes: 42329 lines changed: 2 ins; 42324 del; 3 mod; 8859 unchg
Patch of changes: illumos-gfx.patch
Printable review: illumos-gfx.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/closed-bins

8299 It's time for the old AGP+DRM code to go
1 line changed: 1 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/devfsadm/i386/Makefile

8299 It's time for the old AGP+DRM code to go
1 line changed: 0 ins; 1 del; 0 mod; 32 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/devfsadm/i386/drm_link_i386.c (deleted)

8299 It's time for the old AGP+DRM code to go
318 lines changed: 0 ins; 318 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man7d/Makefile

8299 It's time for the old AGP+DRM code to go
2 lines changed: 0 ins; 2 del; 0 mod; 291 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man7d/i915.7d (deleted)

8299 It's time for the old AGP+DRM code to go
70 lines changed: 0 ins; 70 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man7d/radeon.7d (deleted)

8299 It's time for the old AGP+DRM code to go
69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man7i/Makefile

8299 It's time for the old AGP+DRM code to go
1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man7i/agpgart_io.7i (deleted)

8299 It's time for the old AGP+DRM code to go
926 lines changed: 0 ins; 926 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/pkg/manifests/driver-graphics-agpgart.mf (deleted)

8299 It's time for the old AGP+DRM code to go
98 lines changed: 0 ins; 98 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/pkg/manifests/driver-graphics-drm.mf (deleted)

8299 It's time for the old AGP+DRM code to go
89 lines changed: 0 ins; 89 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/pkg/manifests/system-header-header-agp.mf (deleted)

8299 It's time for the old AGP+DRM code to go
48 lines changed: 0 ins; 48 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

8299 It's time for the old AGP+DRM code to go
6 lines changed: 0 ins; 6 del; 0 mod; 2213 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.rules

8299 It's time for the old AGP+DRM code to go
7 lines changed: 0 ins; 7 del; 0 mod; 2795 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/THIRDPARTYLICENSE (deleted)

8299 It's time for the old AGP+DRM code to go
314 lines changed: 0 ins; 314 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/THIRDPARTYLICENSE.descrip (deleted)

8299 It's time for the old AGP+DRM code to go
1 line changed: 0 ins; 1 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/ati_pcigart.c (deleted)

8299 It's time for the old AGP+DRM code to go
128 lines changed: 0 ins; 128 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm.h (deleted)

8299 It's time for the old AGP+DRM code to go
865 lines changed: 0 ins; 865 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drmP.h (deleted)

8299 It's time for the old AGP+DRM code to go
1103 lines changed: 0 ins; 1103 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_agpsupport.c (deleted)

8299 It's time for the old AGP+DRM code to go
587 lines changed: 0 ins; 587 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_atomic.h (deleted)

8299 It's time for the old AGP+DRM code to go
94 lines changed: 0 ins; 94 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_auth.c (deleted)

8299 It's time for the old AGP+DRM code to go
173 lines changed: 0 ins; 173 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_bufs.c (deleted)

8299 It's time for the old AGP+DRM code to go
897 lines changed: 0 ins; 897 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_cache.c (deleted)

8299 It's time for the old AGP+DRM code to go
66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_context.c (deleted)

8299 It's time for the old AGP+DRM code to go
447 lines changed: 0 ins; 447 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_dma.c (deleted)

8299 It's time for the old AGP+DRM code to go
157 lines changed: 0 ins; 157 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_drawable.c (deleted)

8299 It's time for the old AGP+DRM code to go
74 lines changed: 0 ins; 74 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_drv.c (deleted)

8299 It's time for the old AGP+DRM code to go
577 lines changed: 0 ins; 577 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_fops.c (deleted)

8299 It's time for the old AGP+DRM code to go
131 lines changed: 0 ins; 131 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_gem.c (deleted)

8299 It's time for the old AGP+DRM code to go
698 lines changed: 0 ins; 698 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_io32.h (deleted)

8299 It's time for the old AGP+DRM code to go
187 lines changed: 0 ins; 187 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_ioctl.c (deleted)

8299 It's time for the old AGP+DRM code to go
424 lines changed: 0 ins; 424 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_irq.c (deleted)

8299 It's time for the old AGP+DRM code to go
581 lines changed: 0 ins; 581 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_kstat.c (deleted)

8299 It's time for the old AGP+DRM code to go
99 lines changed: 0 ins; 99 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_linux_list.h (deleted)

8299 It's time for the old AGP+DRM code to go
99 lines changed: 0 ins; 99 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_lock.c (deleted)

8299 It's time for the old AGP+DRM code to go
190 lines changed: 0 ins; 190 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_memory.c (deleted)

8299 It's time for the old AGP+DRM code to go
221 lines changed: 0 ins; 221 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_mm.c (deleted)

8299 It's time for the old AGP+DRM code to go
336 lines changed: 0 ins; 336 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_msg.c (deleted)

8299 It's time for the old AGP+DRM code to go
59 lines changed: 0 ins; 59 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_pci.c (deleted)

8299 It's time for the old AGP+DRM code to go
349 lines changed: 0 ins; 349 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_sarea.h (deleted)

8299 It's time for the old AGP+DRM code to go
81 lines changed: 0 ins; 81 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_scatter.c (deleted)

8299 It's time for the old AGP+DRM code to go
184 lines changed: 0 ins; 184 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_sunmod.c (deleted)

8299 It's time for the old AGP+DRM code to go
1010 lines changed: 0 ins; 1010 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/drm_sunmod.h (deleted)

8299 It's time for the old AGP+DRM code to go
157 lines changed: 0 ins; 157 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/io/drm/queue.h (deleted)

8299 It's time for the old AGP+DRM code to go
585 lines changed: 0 ins; 585 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/Makefile

8299 It's time for the old AGP+DRM code to go
6 lines changed: 0 ins; 6 del; 0 mod; 1333 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/Makefile.syshdrs

8299 It's time for the old AGP+DRM code to go
3 lines changed: 1 ins; 0 del; 2 mod; 466 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/THIRDPARTYLICENSE.agpgart (deleted)

8299 It's time for the old AGP+DRM code to go
23 lines changed: 0 ins; 23 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/THIRDPARTYLICENSE.agpgart.descrip (deleted)

8299 It's time for the old AGP+DRM code to go
1 line changed: 0 ins; 1 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/agp/agpamd64gart_io.h (deleted)

8299 It's time for the old AGP+DRM code to go
40 lines changed: 0 ins; 40 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/agp/agpdefs.h (deleted)

8299 It's time for the old AGP+DRM code to go
354 lines changed: 0 ins; 354 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/agp/agpgart_impl.h (deleted)

8299 It's time for the old AGP+DRM code to go
179 lines changed: 0 ins; 179 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/agp/agpmaster_io.h (deleted)

8299 It's time for the old AGP+DRM code to go
100 lines changed: 0 ins; 100 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/agp/agptarget_io.h (deleted)

8299 It's time for the old AGP+DRM code to go
48 lines changed: 0 ins; 48 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/common/sys/agpgart.h (deleted)

8299 It's time for the old AGP+DRM code to go
148 lines changed: 0 ins; 148 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.files

8299 It's time for the old AGP+DRM code to go
4 lines changed: 0 ins; 4 del; 0 mod; 331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.intel

8299 It's time for the old AGP+DRM code to go
7 lines changed: 0 ins; 7 del; 0 mod; 732 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.rules

8299 It's time for the old AGP+DRM code to go
21 lines changed: 0 ins; 21 del; 0 mod; 492 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/agpgart/Makefile (deleted)

8299 It's time for the old AGP+DRM code to go
73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/agpmaster/Makefile (deleted)

8299 It's time for the old AGP+DRM code to go
97 lines changed: 0 ins; 97 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/agptarget/Makefile (deleted)

8299 It's time for the old AGP+DRM code to go
67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/amd64_gart/Makefile (deleted)

8299 It's time for the old AGP+DRM code to go
62 lines changed: 0 ins; 62 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/drm/Makefile (deleted)

8299 It's time for the old AGP+DRM code to go
90 lines changed: 0 ins; 90 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/i915/Makefile (deleted)

8299 It's time for the old AGP+DRM code to go
93 lines changed: 0 ins; 93 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/agpgart/agp_kstat.c (deleted)

8299 It's time for the old AGP+DRM code to go
138 lines changed: 0 ins; 138 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/agpgart/agpgart.c (deleted)

8299 It's time for the old AGP+DRM code to go
3529 lines changed: 0 ins; 3529 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/agpgart/agpgart.conf (deleted)

8299 It's time for the old AGP+DRM code to go
8 lines changed: 0 ins; 8 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/agpgart/agptarget.c (deleted)

8299 It's time for the old AGP+DRM code to go
953 lines changed: 0 ins; 953 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/agpgart/amd64_gart.c (deleted)

8299 It's time for the old AGP+DRM code to go
439 lines changed: 0 ins; 439 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/agpmaster/agpmaster.c (deleted)

8299 It's time for the old AGP+DRM code to go
732 lines changed: 0 ins; 732 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/drm_pciids.h (deleted)

8299 It's time for the old AGP+DRM code to go
219 lines changed: 0 ins; 219 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_dma.c (deleted)

8299 It's time for the old AGP+DRM code to go
1146 lines changed: 0 ins; 1146 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_drm.h (deleted)

8299 It's time for the old AGP+DRM code to go
742 lines changed: 0 ins; 742 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_drv.c (deleted)

8299 It's time for the old AGP+DRM code to go
1047 lines changed: 0 ins; 1047 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_drv.h (deleted)

8299 It's time for the old AGP+DRM code to go
1842 lines changed: 0 ins; 1842 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_gem.c (deleted)

8299 It's time for the old AGP+DRM code to go
2919 lines changed: 0 ins; 2919 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_gem_debug.c (deleted)

8299 It's time for the old AGP+DRM code to go
1108 lines changed: 0 ins; 1108 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_gem_tiling.c (deleted)

8299 It's time for the old AGP+DRM code to go
390 lines changed: 0 ins; 390 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_irq.c (deleted)

8299 It's time for the old AGP+DRM code to go
1052 lines changed: 0 ins; 1052 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/i915_mem.c (deleted)

8299 It's time for the old AGP+DRM code to go
425 lines changed: 0 ins; 425 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/r300_cmdbuf.c (deleted)

8299 It's time for the old AGP+DRM code to go
987 lines changed: 0 ins; 987 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/r300_reg.h (deleted)

8299 It's time for the old AGP+DRM code to go
1516 lines changed: 0 ins; 1516 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_cp.c (deleted)

8299 It's time for the old AGP+DRM code to go
2387 lines changed: 0 ins; 2387 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_drm.h (deleted)

8299 It's time for the old AGP+DRM code to go
800 lines changed: 0 ins; 800 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_drv.c (deleted)

8299 It's time for the old AGP+DRM code to go
298 lines changed: 0 ins; 298 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_drv.h (deleted)

8299 It's time for the old AGP+DRM code to go
1203 lines changed: 0 ins; 1203 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_io32.h (deleted)

8299 It's time for the old AGP+DRM code to go
173 lines changed: 0 ins; 173 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_irq.c (deleted)

8299 It's time for the old AGP+DRM code to go
376 lines changed: 0 ins; 376 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_mem.c (deleted)

8299 It's time for the old AGP+DRM code to go
353 lines changed: 0 ins; 353 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/io/drm/radeon_state.c (deleted)

8299 It's time for the old AGP+DRM code to go
3530 lines changed: 0 ins; 3530 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/uts/intel/radeon/Makefile (deleted)

8299 It's time for the old AGP+DRM code to go
91 lines changed: 0 ins; 91 del; 0 mod; 0 unchg

This code review page was prepared using /tank/ws/illumos-gfx/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.