Code Review for 4701

Prepared by:Matt Barden (mbarden) on 2014-Jul-09 16:04 -0400 EDT
Workspace:/home/mbarden/ws/illumos-gate (at 5a19962ffeab)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 5cb0d67909d9)
Summary of changes: 309015 lines changed: 308978 ins; 3 del; 34 mod; 1859 unchg
Patch of changes: 4701.patch
Printable review: 4701.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/grep_xpg4/grep.c

4701 would like grep context options (-A, -B, -C)
358 lines changed: 323 ins; 3 del; 32 mod; 1244 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/grep.1

4701 would like grep context options (-A, -B, -C)
39 lines changed: 38 ins; 0 del; 1 mod; 537 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-utiltest.mf

4701 would like grep context options (-A, -B, -C)
74 lines changed: 74 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/runfiles/default.run

4701 would like grep context options (-A, -B, -C)
3 lines changed: 3 ins; 0 del; 0 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/Makefile

4701 would like grep context options (-A, -B, -C)
2 lines changed: 1 ins; 0 del; 1 mod; 18 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/Makefile

4701 would like grep context options (-A, -B, -C)
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/Makefile

4701 would like grep context options (-A, -B, -C)
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout0

4701 would like grep context options (-A, -B, -C)
757 lines changed: 757 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout1

4701 would like grep context options (-A, -B, -C)
757 lines changed: 757 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout10

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout11

4701 would like grep context options (-A, -B, -C)
10145 lines changed: 10145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout12

4701 would like grep context options (-A, -B, -C)
10145 lines changed: 10145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout13

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout14

4701 would like grep context options (-A, -B, -C)
5271 lines changed: 5271 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout15

4701 would like grep context options (-A, -B, -C)
5271 lines changed: 5271 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout16

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout17

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout18

4701 would like grep context options (-A, -B, -C)
10145 lines changed: 10145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout19

4701 would like grep context options (-A, -B, -C)
10145 lines changed: 10145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout2

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout20

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout21

4701 would like grep context options (-A, -B, -C)
8784 lines changed: 8784 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout22

4701 would like grep context options (-A, -B, -C)
8784 lines changed: 8784 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout23

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout24

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout25

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout26

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout27

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout28

4701 would like grep context options (-A, -B, -C)
6711 lines changed: 6711 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout29

4701 would like grep context options (-A, -B, -C)
6711 lines changed: 6711 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout3

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout30

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout31

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout32

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout33

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout34

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout35

4701 would like grep context options (-A, -B, -C)
6711 lines changed: 6711 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout36

4701 would like grep context options (-A, -B, -C)
6711 lines changed: 6711 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout37

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout38

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout39

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout4

4701 would like grep context options (-A, -B, -C)
9383 lines changed: 9383 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout40

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout41

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout42

4701 would like grep context options (-A, -B, -C)
8784 lines changed: 8784 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout43

4701 would like grep context options (-A, -B, -C)
8784 lines changed: 8784 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout44

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout45

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout46

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout47

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout48

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout49

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout5

4701 would like grep context options (-A, -B, -C)
9383 lines changed: 9383 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout50

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout51

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout52

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout53

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout54

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout55

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout56

4701 would like grep context options (-A, -B, -C)
6016 lines changed: 6016 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout57

4701 would like grep context options (-A, -B, -C)
6016 lines changed: 6016 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout58

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout59

4701 would like grep context options (-A, -B, -C)
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout6

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout60

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout61

4701 would like grep context options (-A, -B, -C)
10147 lines changed: 10147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout62

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout7

4701 would like grep context options (-A, -B, -C)
5262 lines changed: 5262 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout8

4701 would like grep context options (-A, -B, -C)
5262 lines changed: 5262 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/gout9

4701 would like grep context options (-A, -B, -C)
8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test0

4701 would like grep context options (-A, -B, -C)
13 lines changed: 13 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test1

4701 would like grep context options (-A, -B, -C)
152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test2

4701 would like grep context options (-A, -B, -C)
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test3

4701 would like grep context options (-A, -B, -C)
14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test4

4701 would like grep context options (-A, -B, -C)
9256 lines changed: 9256 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test5

4701 would like grep context options (-A, -B, -C)
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test6

4701 would like grep context options (-A, -B, -C)
416 lines changed: 416 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/files/test7

4701 would like grep context options (-A, -B, -C)
208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/grep_xpg4/grep_test.ksh

4701 would like grep context options (-A, -B, -C)
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.