Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-Aug-12 07:52 -0700 PDT
Workspace:/ws/garrett/illumos-gate (at 8d8b75b42bc3)
Compare against: master (at ed7418ae3db7)
Summary of changes: 5430 lines changed: 1621 ins; 1499 del; 2310 mod; 16072 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/ifparse/Makefile

UNIX98 requires unistd.h for getopt, and requires -D_XOPEN_SOURCE=500.
3 lines changed: 0 ins; 0 del; 3 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/ifparse/ifparse.c

UNIX98 requires unistd.h for getopt, and requires -D_XOPEN_SOURCE=500.
1 line changed: 1 ins; 0 del; 0 mod; 572 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mandoc/mdoc.h

Various tweaks -- add our sections, etc.
4 lines changed: 4 ins; 0 del; 0 mod; 392 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mandoc/mdoc_validate.c

Various tweaks -- add our sections, etc.
4 lines changed: 4 ins; 0 del; 0 mod; 2403 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/dirent.h

reorder rewinddir prototype/define
Build fixes.
opendir, dirfd are in XPG7
alphasort and scandir are new in XPG7
127 lines changed: 13 ins; 105 del; 9 mod; 198 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/wchar_iso.h

Fixes for wcstok.
1 line changed: 0 ins; 0 del; 1 mod; 453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/netdb.h

Finished obsoleting interfaces for XPG7.
92 lines changed: 11 ins; 80 del; 1 mod; 398 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/pthread.h

code review feeback, close open comment
pthread_attr_setstackaddr removed in XPG7
126 lines changed: 8 ins; 118 del; 0 mod; 354 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/signal.h

first round of POSIX 2008 stuff
124 lines changed: 5 ins; 114 del; 5 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/stdio.h

oops!
getdelim.3c should list p1003.1-2008.
more ifdef cleanups, expose getline and getdelim
132 lines changed: 4 ins; 113 del; 15 mod; 361 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/stdlib.h

first round of POSIX 2008 stuff
135 lines changed: 8 ins; 127 del; 0 mod; 263 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/strings.h

code review feeback, close open comment
first round of POSIX 2008 stuff
26 lines changed: 1 ins; 22 del; 3 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/ucontext.h

code review feeback, close open comment
first round of POSIX 2008 stuff
37 lines changed: 13 ins; 24 del; 0 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/unistd.h

Build fixes.
code review feeback, close open comment
Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
first round of POSIX 2008 stuff
561 lines changed: 49 ins; 470 del; 42 mod; 609 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/wchar.h

Finished obsoleting interfaces for XPG7.
45 lines changed: 4 ins; 41 del; 0 mod; 197 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/Makefile.man

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
4 lines changed: 2 ins; 2 del; 0 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/catman.1m

manlint and minor markup fixes
6 lines changed: 2 ins; 2 del; 2 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man2/access.2

markup tweaks per mandoc author
fcntl.h only needed for faccessat
copyright
document standards for access, faccess
Unexpected Error occurred reading `diff -e old/usr/src/man/man2/access.2 new/usr/src/man/man2/access.2`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man2/chmod.2

fchmod is standard
added fchmodat, etc.
Unexpected Error occurred reading `diff -e old/usr/src/man/man2/chmod.2 new/usr/src/man/man2/chmod.2`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man2/getcontext.2

Minor markup tweaks (Sy instead of Nm).
first round of POSIX 2008 stuff
137 lines changed: 51 ins; 4 del; 82 mod; 17 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/Makefile

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
15 lines changed: 13 ins; 2 del; 0 mod; 2305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/bsd_signal.3c

Minor markup tweaks (Sy instead of Nm).
fix incorrect standard citations
first round of POSIX 2008 stuff
88 lines changed: 5 ins; 11 del; 72 mod; 21 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/bstring.3c

Minor markup tweaks (Sy instead of Nm).
first round of POSIX 2008 stuff
87 lines changed: 18 ins; 12 del; 57 mod; 6 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/dirfd.3c

opendir, dirfd are in XPG7
Unexpected Error occurred reading `diff -e old/usr/src/man/man3c/dirfd.3c new/usr/src/man/man3c/dirfd.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/ecvt.3c

Minor markup tweaks (Sy instead of Nm).
fix incorrect standard citations
first round of POSIX 2008 stuff
129 lines changed: 30 ins; 6 del; 93 mod; 20 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/ftime.3c

Minor markup tweaks (Sy instead of Nm).
fix incorrect standard citations
first round of POSIX 2008 stuff
84 lines changed: 9 ins; 1 del; 74 mod; 15 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/getline.3c

Whoops!  Wrong file modified!
Unexpected Error occurred reading `diff -e old/usr/src/man/man3c/getline.3c new/usr/src/man/man3c/getline.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/getwd.3c

Minor markup tweaks (Sy instead of Nm).
first round of POSIX 2008 stuff
55 lines changed: 1 ins; 5 del; 49 mod; 14 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/index.3c

Minor markup tweaks (Sy instead of Nm).
first round of POSIX 2008 stuff
77 lines changed: 10 ins; 11 del; 56 mod; 10 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/makecontext.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Update libraries and sections.
More markup tweaks.
Minor markup tweaks (Sy instead of Nm).
fix incorrect standard citations
first round of POSIX 2008 stuff
182 lines changed: 29 ins; 12 del; 141 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/mktemp.3c

fix incorrect standard citations
76 lines changed: 8 ins; 11 del; 57 mod; 21 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/newlocale.3c

Add locale.h ref
Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Note standards conformance for newlocale, convert to mdocml.
Unexpected Error occurred reading `diff -e old/usr/src/man/man3c/newlocale.3c new/usr/src/man/man3c/newlocale.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/opendir.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
opendir, dirfd are in XPG7
Unexpected Error occurred reading `diff -e old/usr/src/man/man3c/opendir.3c new/usr/src/man/man3c/opendir.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/pthread_attr_getstackaddr.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Update libraries and sections.
More markup tweaks.
no need to use -lpthread anymore
pthread_attr_setstackaddr removed in XPG7
104 lines changed: 15 ins; 0 del; 89 mod; 12 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/scandir.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Various tweaks -- add our sections, etc.
Update libraries and sections.
More markup tweaks.
alphasort and scandir are new in XPG7
Unexpected Error occurred reading `diff -e old/usr/src/man/man3c/scandir.3c new/usr/src/man/man3c/scandir.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/ualarm.3c

Document obsolescence of ualarm.
75 lines changed: 16 ins; 1 del; 58 mod; 12 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/usleep.3c

oops, dropped leading 'f'
Minor markup tweaks (Sy instead of Nm).
fix incorrect standard citations
first round of POSIX 2008 stuff
64 lines changed: 4 ins; 7 del; 53 mod; 13 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/wcscasecmp.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Unexpected Error occurred reading `diff -e /dev/null new/usr/src/man/man3c/wcscasecmp.3c`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/wcsdup.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Unexpected Error occurred reading `diff -e /dev/null new/usr/src/man/man3c/wcsdup.3c`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/wcslen.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Unexpected Error occurred reading `diff -e /dev/null new/usr/src/man/man3c/wcslen.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wcstring.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Various tweaks -- add our sections, etc.
Fixes for wcstok.
Finished obsoleting interfaces for XPG7.
Unexpected Error occurred reading `diff -e old/usr/src/man/man3c/wcstring.3c new/usr/src/man/man3c/wcstring.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wstring.3c

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Unexpected Error occurred reading `diff -e old/usr/src/man/man3c/wstring.3c new/usr/src/man/man3c/wstring.3c`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3head/timeb.h.3head

Minor markup tweaks (Sy instead of Nm).
first round of POSIX 2008 stuff
49 lines changed: 0 ins; 10 del; 39 mod; 8 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3head/ucontext.h.3head

Minor markup tweaks (Sy instead of Nm).
fix incorrect standard citations
first round of POSIX 2008 stuff
67 lines changed: 4 ins; 4 del; 59 mod; 6 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3head/wchar.h.3head

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Unexpected Error occurred reading `diff -e old/usr/src/man/man3head/wchar.h.3head new/usr/src/man/man3head/wchar.h.3head`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3lib/libc.3lib

Add getdelim, getline to libc symbols.
add wcscasecmp & friends
Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
1835 lines changed: 812 ins; 49 del; 974 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3nsl/Makefile

Finished obsoleting interfaces for XPG7.
11 lines changed: 6 ins; 5 del; 0 mod; 569 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3nsl/gethostbyname.3nsl

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
Finished obsoleting interfaces for XPG7.
441 lines changed: 117 ins; 80 del; 244 mod; 87 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3nsl/gethostent.3nsl

Finished obsoleting interfaces for XPG7.
288 lines changed: 288 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/man.5

Minor markup tweaks (Sy instead of Nm).
1 line changed: 0 ins; 0 del; 1 mod; 253 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/mdoc.5

Minor markup tweaks (Sy instead of Nm).
23 lines changed: 0 ins; 0 del; 23 mod; 3184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3c.inc

Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
7 lines changed: 6 ins; 0 del; 1 mod; 1359 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3nsl.inc

Finished obsoleting interfaces for XPG7.
6 lines changed: 2 ins; 1 del; 3 mod; 342 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/feature_tests.h

Finished obsoleting interfaces for XPG7.
26 lines changed: 26 ins; 0 del; 0 mod; 431 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/stat.h

Build fixes.
code review feeback, close open comment
Ensured various XPG7 stuff are declared properly in sys/stat.h (and cleanup)
New documentation for wcslen, wcsnlen, wcscasecmp (and friends), wcsdup.
Various other tweaks and markup improvements.
51 lines changed: 4 ins; 44 del; 3 mod; 516 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/timeb.h

code review feeback, close open comment
first round of POSIX 2008 stuff
24 lines changed: 18 ins; 5 del; 1 mod; 67 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.