Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-Jun-29 11:52 -0700 PDT
Workspace:/ws/garrett/illumos-gate (at 8109a0993400)
Compare against: 4398ff1496dddcc2dfa23efee97b17e3921712d5 (at 4398ff1496dd)
Summary of changes: 2572 lines changed: 1038 ins; 950 del; 584 mod; 13358 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/wctype.h

Thread safety fixes.
1 line changed: 1 ins; 0 del; 0 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/collate.c

Thread safety fixes.
1 line changed: 0 ins; 1 del; 0 mod; 649 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmessages.c

Thread safety fixes.
2 lines changed: 0 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmonetary.c

Thread safety fixes.
2 lines changed: 0 ins; 1 del; 1 mod; 178 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lnumeric.c

Thread safety fixes.
4 lines changed: 0 ins; 2 del; 2 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/localeimpl.c

Thread safety fixes.
150 lines changed: 69 ins; 50 del; 31 mod; 395 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/localeimpl.h

Thread safety fixes.
5 lines changed: 1 ins; 1 del; 3 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/mblen.c

Thread safety fixes.
4 lines changed: 0 ins; 2 del; 2 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/mbtowc.c

Thread safety fixes.
4 lines changed: 0 ins; 2 del; 2 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setlocale.c

Thread safety fixes.
43 lines changed: 30 ins; 4 del; 9 mod; 168 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setrunelocale.c

Thread safety fixes.
3 lines changed: 0 ins; 1 del; 2 mod; 146 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/timelocal.c

Thread safety fixes.
2 lines changed: 0 ins; 1 del; 1 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/wctomb.c

Thread safety fixes.
4 lines changed: 0 ins; 2 del; 2 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/Makefile

Garrett's man page edits.
188 lines changed: 183 ins; 5 del; 0 mod; 2114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/btowc.3c

Garrett's man page edits.
35 lines changed: 13 ins; 15 del; 7 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/ctype.3c

Garrett's man page edits.
47 lines changed: 4 ins; 37 del; 6 mod; 307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/fgetwc.3c

Garrett's man page edits.
115 lines changed: 17 ins; 62 del; 36 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/getwc.3c

Garrett's man page edits.
33 lines changed: 14 ins; 9 del; 10 mod; 53 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/iswalpha.3c

Garrett's man page edits.
85 lines changed: 6 ins; 57 del; 22 mod; 400 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/iswctype.3c

Garrett's man page edits.
90 lines changed: 40 ins; 16 del; 34 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/mblen.3c

Garrett's man page edits.
41 lines changed: 15 ins; 12 del; 14 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/mbrlen.3c

Garrett's man page edits.
51 lines changed: 23 ins; 15 del; 13 mod; 125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/mbrtowc.3c

Garrett's man page edits.
170 lines changed: 65 ins; 33 del; 72 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/mbsinit.3c

Garrett's man page edits.
38 lines changed: 15 ins; 18 del; 5 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/mbsrtowcs.3c

Garrett's man page edits.
74 lines changed: 20 ins; 21 del; 33 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/mbtowc.3c

Garrett's man page edits.
40 lines changed: 14 ins; 18 del; 8 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/newlocale.3c

Garrett's man page edits.
141 lines changed: 7 ins; 99 del; 35 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/nl_langinfo.3c

Garrett's man page edits.
33 lines changed: 6 ins; 19 del; 8 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/strcoll.3c

Garrett's man page edits.
35 lines changed: 7 ins; 20 del; 8 mod; 80 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3c/strfmon.3c

Garrett's man page edits.
164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/strftime.3c

Garrett's man page edits.
55 lines changed: 10 ins; 31 del; 14 mod; 746 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/string.3c

Garrett's man page edits.
104 lines changed: 21 ins; 75 del; 8 mod; 503 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/strptime.3c

Garrett's man page edits.
34 lines changed: 10 ins; 20 del; 4 mod; 686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/strxfrm.3c

Garrett's man page edits.
42 lines changed: 6 ins; 27 del; 9 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/tolower.3c

Garrett's man page edits.
18 lines changed: 4 ins; 9 del; 5 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/toupper.3c

Garrett's man page edits.
20 lines changed: 5 ins; 9 del; 6 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/towlower.3c

Garrett's man page edits.
31 lines changed: 4 ins; 13 del; 14 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/towupper.3c

Garrett's man page edits.
32 lines changed: 4 ins; 13 del; 15 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/uselocale.3c

Garrett's man page edits.
72 lines changed: 14 ins; 41 del; 17 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wcrtomb.3c

Garrett's man page edits.
51 lines changed: 16 ins; 25 del; 10 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wcscoll.3c

Garrett's man page edits.
43 lines changed: 6 ins; 17 del; 20 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wcsrtombs.3c

Garrett's man page edits.
49 lines changed: 12 ins; 24 del; 13 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wctob.3c

Garrett's man page edits.
36 lines changed: 11 ins; 16 del; 9 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wctomb.3c

Garrett's man page edits.
33 lines changed: 11 ins; 17 del; 5 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wctrans.3c

Garrett's man page edits.
99 lines changed: 13 ins; 51 del; 35 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wctype.3c

Garrett's man page edits.
34 lines changed: 6 ins; 12 del; 16 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/wcwidth.3c

Garrett's man page edits.
30 lines changed: 11 ins; 11 del; 8 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3head/Makefile

Garrett's man page edits.
5 lines changed: 3 ins; 0 del; 2 mod; 287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3head/locale.h.3head

Garrett's man page edits.
27 lines changed: 15 ins; 11 del; 1 mod; 130 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man3head/xlocale.h.3head

Garrett's man page edits.
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/environ.5

Garrett's man page edits.
12 lines changed: 3 ins; 4 del; 5 mod; 525 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf

Garrett's man page edits.
3 lines changed: 2 ins; 0 del; 1 mod; 2131 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3c.inc

Garrett's man page edits.
78 lines changed: 78 ins; 0 del; 0 mod; 1277 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.