Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-May-09 12:12 -0700 PDT
Workspace:/ws/garrett/illumos-gate (at 6621ffb0c9d2)
Compare against: a7175e2030b8105e954880bdc63bf0e3dba62d2c (at a7175e2030b8)
Summary of changes: 688 lines changed: 653 ins; 11 del; 24 mod; 540 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/printf/printf.c

4854 printf(1) doesn't support %b and \c properly
4818 printf(1) should support n$ width and precision specifiers
118 lines changed: 84 ins; 11 del; 23 mod; 521 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-test-utiltest.mf

4818 printf(1) should support n$ width and precision specifiers
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/Makefile

4854 printf(1) doesn't support %b and \c properly
2 lines changed: 1 ins; 0 del; 1 mod; 19 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/Makefile

4818 printf(1) should support n$ width and precision specifiers
20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/cmd/Makefile

4818 printf(1) should support n$ width and precision specifiers
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/cmd/utiltest.ksh

4818 printf(1) should support n$ width and precision specifiers
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/doc/Makefile

4818 printf(1) should support n$ width and precision specifiers
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/doc/README

4818 printf(1) should support n$ width and precision specifiers
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/runfiles/Makefile

4818 printf(1) should support n$ width and precision specifiers
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/runfiles/default.run

4818 printf(1) should support n$ width and precision specifiers
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/Makefile

4818 printf(1) should support n$ width and precision specifiers
19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/printf/Makefile

4818 printf(1) should support n$ width and precision specifiers
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/printf/printf_test.ksh

4854 printf(1) doesn't support %b and \c properly
4818 printf(1) should support n$ width and precision specifiers
193 lines changed: 193 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.