Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-Jun-02 23:06 -0700 PDT
Workspace:/ws/garrett/illumos-gate (at c0d41e9b8316)
Compare against: 4f593dce8665879c351ba0bff925bbb0ffab3a5e (at 4f593dce8665)
Summary of changes: 664 lines changed: 616 ins; 5 del; 43 mod; 4166 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/locale.h

Fix compile errors, code review feedback, and add basic libc test suite.
10 lines changed: 0 ins; 0 del; 10 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/xlocale.h

Fix compile errors, code review feedback, and add basic libc test suite.
34 lines changed: 5 ins; 5 del; 24 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/localeimpl.c

Fix compile errors, code review feedback, and add basic libc test suite.
11 lines changed: 6 ins; 0 del; 5 mod; 465 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/localeimpl.h

Fix compile errors, code review feedback, and add basic libc test suite.
1 line changed: 1 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setlocale.c

Fix compile errors, code review feedback, and add basic libc test suite.
4 lines changed: 0 ins; 0 del; 4 mod; 177 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers

Fix compile errors, code review feedback, and add basic libc test suite.
2 lines changed: 2 ins; 0 del; 0 mod; 3239 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-test-libctest.mf

Fix compile errors, code review feedback, and add basic libc test suite.
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/Makefile

Fix compile errors, code review feedback, and add basic libc test suite.
21 lines changed: 21 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/cmd/Makefile

Fix compile errors, code review feedback, and add basic libc test suite.
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/cmd/libctest.ksh

Fix compile errors, code review feedback, and add basic libc test suite.
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/doc/Makefile

Fix compile errors, code review feedback, and add basic libc test suite.
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/doc/README

Fix compile errors, code review feedback, and add basic libc test suite.
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/runfiles/Makefile

Fix compile errors, code review feedback, and add basic libc test suite.
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/runfiles/default.run

Fix compile errors, code review feedback, and add basic libc test suite.
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/tests/Makefile

Fix compile errors, code review feedback, and add basic libc test suite.
19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/tests/newlocale/Makefile

Fix compile errors, code review feedback, and add basic libc test suite.
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/tests/newlocale/newlocale_test.c

Fix compile errors, code review feedback, and add basic libc test suite.
195 lines changed: 195 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.