Print this page
Update to 1.12.3.

@@ -1,9 +1,9 @@
-/*      $Id: read.c,v 1.28 2012/02/16 20:51:31 joerg Exp $ */
+/*      $Id: read.c,v 1.39 2013/09/16 00:25:07 schwarze Exp $ */
 /*
  * Copyright (c) 2008, 2009, 2010, 2011 Kristaps Dzonsons <kristaps@bsd.lv>
- * Copyright (c) 2010, 2011 Ingo Schwarze <schwarze@openbsd.org>
+ * Copyright (c) 2010, 2011, 2012, 2013 Ingo Schwarze <schwarze@openbsd.org>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
  * copyright notice and this permission notice appear in all copies.
  *

@@ -38,14 +38,10 @@
 #include "libmandoc.h"
 #include "mdoc.h"
 #include "man.h"
 #include "main.h"
 
-#ifndef MAP_FILE
-#define MAP_FILE        0
-#endif
-
 #define REPARSE_LIMIT   1000
 
 struct  buf {
         char             *buf; /* binary input buffer */
         size_t            sz; /* size of binary buffer */

@@ -64,18 +60,20 @@
         int               reparse_count; /* finite interp. stack */
         mandocmsg         mmsg; /* warning/error message handler */
         void             *arg; /* argument to mmsg */
         const char       *file; 
         struct buf       *secondary;
+        char             *defos; /* default operating system */
 };
 
 static  void      resize_buf(struct buf *, size_t);
 static  void      mparse_buf_r(struct mparse *, struct buf, int);
-static  void      mparse_readfd_r(struct mparse *, int, const char *, int);
 static  void      pset(const char *, int, struct mparse *);
 static  int       read_whole_file(const char *, int, struct buf *, int *);
 static  void      mparse_end(struct mparse *);
+static  void      mparse_parse_buffer(struct mparse *, struct buf,
+                        const char *);
 
 static  const enum mandocerr    mandoclimits[MANDOCLEVEL_MAX] = {
         MANDOCERR_OK,
         MANDOCERR_WARNING,
         MANDOCERR_WARNING,

@@ -92,10 +90,11 @@
 
         /* related to the prologue */
         "no title in document",
         "document title should be all caps",
         "unknown manual section",
+        "unknown manual volume or arch",
         "date missing, using today's date",
         "cannot parse date, using it verbatim",
         "prologue macros out of order",
         "duplicate prologue macro",
         "macro not allowed in prologue",

@@ -103,18 +102,18 @@
 
         /* related to document structure */
         ".so is fragile, better use ln(1)",
         "NAME section must come first",
         "bad NAME section contents",
-        "manual name not yet set",
         "sections out of conventional order",
         "duplicate section name",
-        "section not in conventional manual section",
+        "section header suited to sections 2, 3, and 9 only",
 
         /* related to macros and nesting */
         "skipping obsolete macro",
         "skipping paragraph macro",
+        "moving paragraph macro out of list",
         "skipping no-space macro",
         "blocks badly nested",
         "child violates parent syntax",
         "nested displays are not portable",
         "already in literal mode",

@@ -171,21 +170,24 @@
         "ignoring extra data cells",
 
         "input stack limit exceeded, infinite loop?",
         "skipping bad character",
         "escaped character not allowed in a name",
+        "manual name not yet set",
         "skipping text before the first section header",
         "skipping unknown macro",
         "NOT IMPLEMENTED, please use groff: skipping request",
         "argument count wrong",
+        "skipping column outside column list",
         "skipping end of block that is not open",
         "missing end of block",
         "scope open on exit",
         "uname(3) system call failed",
         "macro requires line argument(s)",
         "macro requires body argument(s)",
         "macro requires argument(s)",
+        "request requires a numeric argument",
         "missing list type",
         "line argument(s) will be lost",
         "body argument(s) will be lost",
 
         "generic fatal error",

@@ -245,11 +247,12 @@
         }
 
         switch (curp->inttype) {
         case (MPARSE_MDOC):
                 if (NULL == curp->pmdoc) 
-                        curp->pmdoc = mdoc_alloc(curp->roff, curp);
+                        curp->pmdoc = mdoc_alloc(curp->roff, curp,
+                                        curp->defos);
                 assert(curp->pmdoc);
                 curp->mdoc = curp->pmdoc;
                 return;
         case (MPARSE_MAN):
                 if (NULL == curp->pman) 

@@ -261,11 +264,12 @@
                 break;
         }
 
         if (pos >= 3 && 0 == memcmp(buf, ".Dd", 3))  {
                 if (NULL == curp->pmdoc) 
-                        curp->pmdoc = mdoc_alloc(curp->roff, curp);
+                        curp->pmdoc = mdoc_alloc(curp->roff, curp,
+                                        curp->defos);
                 assert(curp->pmdoc);
                 curp->mdoc = curp->pmdoc;
                 return;
         } 
 

@@ -321,10 +325,19 @@
                                 ++lnn;
                                 break;
                         }
 
                         /* 
+                         * Make sure we have space for at least
+                         * one backslash and one other character
+                         * and the trailing NUL byte.
+                         */
+
+                        if (pos + 2 >= (int)ln.sz)
+                                resize_buf(&ln, 256);
+
+                        /* 
                          * Warn about bogus characters.  If you're using
                          * non-ASCII encoding, you're screwing your
                          * readers.  Since I'd rather this not happen,
                          * I'll be helpful and replace these characters
                          * with "?", so we don't display gibberish.

@@ -336,21 +349,17 @@
                         if ( ! (isascii(c) && 
                                         (isgraph(c) || isblank(c)))) {
                                 mandoc_msg(MANDOCERR_BADCHAR, curp,
                                                 curp->line, pos, NULL);
                                 i++;
-                                if (pos >= (int)ln.sz)
-                                        resize_buf(&ln, 256);
                                 ln.buf[pos++] = '?';
                                 continue;
                         }
 
                         /* Trailing backslash = a plain char. */
 
                         if ('\\' != blk.buf[i] || i + 1 == (int)blk.sz) {
-                                if (pos >= (int)ln.sz)
-                                        resize_buf(&ln, 256);
                                 ln.buf[pos++] = blk.buf[i++];
                                 continue;
                         }
 
                         /*

@@ -388,15 +397,25 @@
                                                 break;
                                 }
                                 break;
                         }
 
-                        /* Some other escape sequence, copy & cont. */
+                        /* Catch escaped bogus characters. */
 
-                        if (pos + 1 >= (int)ln.sz)
-                                resize_buf(&ln, 256);
+                        c = (unsigned char) blk.buf[i+1];
 
+                        if ( ! (isascii(c) && 
+                                        (isgraph(c) || isblank(c)))) {
+                                mandoc_msg(MANDOCERR_BADCHAR, curp,
+                                                curp->line, pos, NULL);
+                                i += 2;
+                                ln.buf[pos++] = '?';
+                                continue;
+                        }
+
+                        /* Some other escape sequence, copy & cont. */
+
                         ln.buf[pos++] = blk.buf[i++];
                         ln.buf[pos++] = blk.buf[i++];
                 }
 
                 if (pos >= (int)ln.sz)

@@ -467,11 +486,11 @@
                          * buffer because we're going to descend into
                          * the file recursively.
                          */
                         if (curp->secondary) 
                                 curp->secondary->sz -= pos + 1;
-                        mparse_readfd_r(curp, -1, ln.buf + of, 1);
+                        mparse_readfd(curp, -1, ln.buf + of);
                         if (MANDOCLEVEL_FATAL <= curp->file_status)
                                 break;
                         pos = 0;
                         continue;
                 default:

@@ -573,12 +592,11 @@
                         fprintf(stderr, "%s: input too large\n", file);
                         return(0);
                 }
                 *with_mmap = 1;
                 fb->sz = (size_t)st.st_size;
-                fb->buf = mmap(NULL, fb->sz, PROT_READ, 
-                                MAP_FILE|MAP_SHARED, fd, 0);
+                fb->buf = mmap(NULL, fb->sz, PROT_READ, MAP_SHARED, fd, 0);
                 if (fb->buf != MAP_FAILED)
                         return(1);
         }
 #endif
 

@@ -641,23 +659,29 @@
 
         roff_endparse(curp->roff);
 }
 
 static void
-mparse_parse_buffer(struct mparse *curp, struct buf blk, const char *file,
-                int re)
+mparse_parse_buffer(struct mparse *curp, struct buf blk, const char *file)
 {
         const char      *svfile;
+        static int       recursion_depth;
 
+        if (64 < recursion_depth) {
+                mandoc_msg(MANDOCERR_ROFFLOOP, curp, curp->line, 0, NULL);
+                return;
+        }
+
         /* Line number is per-file. */
         svfile = curp->file;
         curp->file = file;
         curp->line = 1;
+        recursion_depth++;
 
         mparse_buf_r(curp, blk, 1);
 
-        if (0 == re && MANDOCLEVEL_FATAL > curp->file_status)
+        if (0 == --recursion_depth && MANDOCLEVEL_FATAL > curp->file_status)
                 mparse_end(curp);
 
         curp->file = svfile;
 }
 

@@ -668,25 +692,25 @@
         struct buf blk;
 
         blk.buf = UNCONST(buf);
         blk.sz = len;
 
-        mparse_parse_buffer(curp, blk, file, 0);
+        mparse_parse_buffer(curp, blk, file);
         return(curp->file_status);
 }
 
-static void
-mparse_readfd_r(struct mparse *curp, int fd, const char *file, int re)
+enum mandoclevel
+mparse_readfd(struct mparse *curp, int fd, const char *file)
 {
         struct buf       blk;
         int              with_mmap;
 
         if (-1 == fd)
                 if (-1 == (fd = open(file, O_RDONLY, 0))) {
                         perror(file);
                         curp->file_status = MANDOCLEVEL_SYSERR;
-                        return;
+                        goto out;
                 }
         /*
          * Run for each opened file; may be called more than once for
          * each full parse sequence if the opened file is nested (i.e.,
          * from `so').  Simply sucks in the whole file and moves into

@@ -693,14 +717,14 @@
          * the parse phase for the file.
          */
 
         if ( ! read_whole_file(file, fd, &blk, &with_mmap)) {
                 curp->file_status = MANDOCLEVEL_SYSERR;
-                return;
+                goto out;
         }
 
-        mparse_parse_buffer(curp, blk, file, re);
+        mparse_parse_buffer(curp, blk, file);
 
 #ifdef  HAVE_MMAP
         if (with_mmap)
                 munmap(blk.buf, blk.sz);
         else

@@ -707,22 +731,17 @@
 #endif
                 free(blk.buf);
 
         if (STDIN_FILENO != fd && -1 == close(fd))
                 perror(file);
-}
-
-enum mandoclevel
-mparse_readfd(struct mparse *curp, int fd, const char *file)
-{
-
-        mparse_readfd_r(curp, fd, file, 0);
+out:
         return(curp->file_status);
 }
 
 struct mparse *
-mparse_alloc(enum mparset inttype, enum mandoclevel wlevel, mandocmsg mmsg, void *arg)
+mparse_alloc(enum mparset inttype, enum mandoclevel wlevel,
+                mandocmsg mmsg, void *arg, char *defos)
 {
         struct mparse   *curp;
 
         assert(wlevel <= MANDOCLEVEL_FATAL);
 

@@ -730,12 +749,13 @@
 
         curp->wlevel = wlevel;
         curp->mmsg = mmsg;
         curp->arg = arg;
         curp->inttype = inttype;
+        curp->defos = defos;
 
-        curp->roff = roff_alloc(curp);
+        curp->roff = roff_alloc(inttype, curp);
         return(curp);
 }
 
 void
 mparse_reset(struct mparse *curp)