Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-Jul-16 14:05 -0700 PDT
Workspace:/ws/garrett/illumos-gate (at 668ee1bade72)
Compare against: mdocml-1.12.1 (at 0934fbd7017f)
Summary of changes: 16017 lines changed: 10029 ins; 5338 del; 650 mod; 2138 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile

mandoc import
9 lines changed: 4 ins; 2 del; 3 mod; 834 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/man/Makefile

Add catman, makewhatis functionality.  Print an error if the whatis database
is missing.
mandoc import
59 lines changed: 13 ins; 28 del; 18 mod; 15 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/THIRDPARTYLICENSE

mandoc import
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/man/THIRDPARTYLICENSE.descrip (renamed from usr/src/cmd/man/src/THIRDPARTYLICENSE.descrip)

mandoc import
0 lines changed: 0 ins; 0 del; 0 mod; 1 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/makewhatis.c

mandoc import
827 lines changed: 827 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/man/man.c

Add catman, makewhatis functionality.  Print an error if the whatis database
is missing.
mandoc import
1603 lines changed: 1603 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/man.h

mandoc import
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/Makefile (deleted)

mandoc import
88 lines changed: 0 ins; 88 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/THIRDPARTYLICENSE (deleted)

mandoc import
32 lines changed: 0 ins; 32 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/getNAME.c (deleted)

mandoc import
789 lines changed: 0 ins; 789 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/makewhatis.sh (deleted)

mandoc import
85 lines changed: 0 ins; 85 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/man.c (deleted)

mandoc import
3336 lines changed: 0 ins; 3336 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/stringlist.c

mandoc import
102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/stringlist.h

mandoc import
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/Makefile

mandoc import
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/THIRDPARTYLICENSE

mandoc import
14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/THIRDPARTYLICENSE.descrip

mandoc import
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/config.h (renamed and modified from usr/src/cmd/mandoc/config.h.post)

mandoc import
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/lib.in

mandoc import
18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/msec.in

mandoc import
244 lines changed: 244 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/Makefile

feedback from Hans
Add catman, makewhatis functionality.  Print an error if the whatis database
is missing.
mandoc import
6 lines changed: 5 ins; 1 del; 0 mod; 749 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/apropos.1

feedback from Hans
mandoc import
142 lines changed: 0 ins; 64 del; 78 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/man.1

feedback from Hans
mandoc import
664 lines changed: 0 ins; 527 del; 137 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/mandoc.1 (renamed and modified from usr/src/cmd/mandoc/mandoc.1)

feedback from Hans
mandoc import
678 lines changed: 678 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch --- usr/src/man/man1/whatis.1

mandoc import
61 lines changed: 0 ins; 61 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/catman.1m

feedback from Hans
mandoc import
373 lines changed: 0 ins; 303 del; 70 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/Makefile

mandoc import
6 lines changed: 5 ins; 0 del; 1 mod; 196 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/eqn.5 (renamed and modified from usr/src/cmd/mandoc/eqn.7)

mandoc import
281 lines changed: 281 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/man.5

feedback from Hans
mandoc import
913 lines changed: 571 ins; 0 del; 342 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/mandoc_char.5 (renamed and modified from usr/src/cmd/mandoc/mandoc_char.7)

mandoc import
744 lines changed: 744 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/mandoc_roff.5 (renamed and modified from usr/src/cmd/mandoc/roff.7)

mandoc import
991 lines changed: 991 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/mdoc.5 (renamed and modified from usr/src/cmd/mandoc/mdoc.7)

feedback from Hans
mandoc import
3211 lines changed: 3211 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/tbl.5 (renamed and modified from usr/src/cmd/mandoc/tbl.7)

mandoc import
349 lines changed: 349 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-man.mf

fix link for catman.
feedback from Hans
Add catman, makewhatis functionality.  Print an error if the whatis database
is missing.
mandoc import
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/text-doctools.mf

mandoc import
25 lines changed: 2 ins; 22 del; 1 mod; 343 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.