Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-Jul-15 13:48 -0700 PDT
Workspace:/ws/garrett/illumos-gate (at 8aeff17eb147)
Compare against: master (at 05b5eb98f5af)
Summary of changes: 44293 lines changed: 38304 ins; 5351 del; 638 mod; 2958 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile

Finish integration.  Use mandoc_preconv, etc.
9 lines changed: 4 ins; 2 del; 3 mod; 834 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/man/Makefile

Initial import of man functionality.
58 lines changed: 12 ins; 28 del; 18 mod; 15 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/THIRDPARTYLICENSE

Initial import of man functionality.
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/cmd/man/THIRDPARTYLICENSE.descrip (renamed from usr/src/cmd/man/src/THIRDPARTYLICENSE.descrip)

Initial import of man functionality.
0 lines changed: 0 ins; 0 del; 0 mod; 1 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/makewhatis.c

Finish integration.  Use mandoc_preconv, etc.
827 lines changed: 827 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/man.c

Finish integration.  Use mandoc_preconv, etc.
import complete (hopefully)
make it compile
Initial import of man functionality.
1567 lines changed: 1567 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/man.h

Finish integration.  Use mandoc_preconv, etc.
Initial import of man functionality.
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/Makefile (deleted)

Initial import of man functionality.
88 lines changed: 0 ins; 88 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/THIRDPARTYLICENSE (deleted)

Initial import of man functionality.
32 lines changed: 0 ins; 32 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/getNAME.c (deleted)

Initial import of man functionality.
789 lines changed: 0 ins; 789 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/makewhatis.sh (deleted)

Initial import of man functionality.
85 lines changed: 0 ins; 85 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/man/src/man.c (deleted)

Initial import of man functionality.
3336 lines changed: 0 ins; 3336 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/stringlist.c

Initial import of man functionality.
102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/man/stringlist.h

Initial import of man functionality.
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/Makefile

Finish integration.  Use mandoc_preconv, etc.
import complete (hopefully)
Initial import of man functionality.
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/THIRDPARTYLICENSE

Initial import of man functionality.
14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/THIRDPARTYLICENSE.descrip

Initial import of man functionality.
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/arch.c

Initial import of man functionality.
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/arch.in

Initial import of man functionality.
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/att.c

Initial import of man functionality.
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/att.in

Initial import of man functionality.
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/chars.c

Initial import of man functionality.
167 lines changed: 167 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/chars.in

Initial import of man functionality.
397 lines changed: 397 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/config.h

Initial import of man functionality.
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/eqn.c

Initial import of man functionality.
949 lines changed: 949 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/eqn_html.c

Initial import of man functionality.
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/eqn_term.c

Initial import of man functionality.
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/html.c

Initial import of man functionality.
699 lines changed: 699 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/html.h

Initial import of man functionality.
164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/lib.c

Initial import of man functionality.
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/lib.in

Initial import of man functionality.
18 lines changed: 18 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/libman.h

Initial import of man functionality.
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/libmandoc.h

Initial import of man functionality.
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/libmdoc.h

Initial import of man functionality.
141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/libroff.h

Initial import of man functionality.
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/main.c

Initial import of man functionality.
401 lines changed: 401 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/main.h

Initial import of man functionality.
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/man.c

Initial import of man functionality.
690 lines changed: 690 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/man.h

Initial import of man functionality.
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/man_hash.c

Initial import of man functionality.
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/man_html.c

Initial import of man functionality.
688 lines changed: 688 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/man_macro.c

Initial import of man functionality.
484 lines changed: 484 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/man_term.c

Initial import of man functionality.
1117 lines changed: 1117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/man_validate.c

Initial import of man functionality.
550 lines changed: 550 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mandoc.c

Initial import of man functionality.
735 lines changed: 735 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mandoc.h

Initial import of man functionality.
432 lines changed: 432 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc.c

Initial import of man functionality.
987 lines changed: 987 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc.h

Initial import of man functionality.
392 lines changed: 392 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc_argv.c

Initial import of man functionality.
716 lines changed: 716 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc_hash.c

Initial import of man functionality.
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc_html.c

Initial import of man functionality.
2284 lines changed: 2284 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc_macro.c

Initial import of man functionality.
1787 lines changed: 1787 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc_man.c

Initial import of man functionality.
637 lines changed: 637 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc_term.c

Initial import of man functionality.
2257 lines changed: 2257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/mdoc_validate.c

Initial import of man functionality.
2403 lines changed: 2403 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/msec.c

Initial import of man functionality.
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/msec.in

Initial import of man functionality.
244 lines changed: 244 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/out.c

Initial import of man functionality.
303 lines changed: 303 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/out.h

Initial import of man functionality.
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/preconv.c

Finish integration.  Use mandoc_preconv, etc.
528 lines changed: 528 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/predefs.in

Initial import of man functionality.
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/read.c

Initial import of man functionality.
846 lines changed: 846 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/roff.c

Initial import of man functionality.
1768 lines changed: 1768 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/st.c

Initial import of man functionality.
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/st.in

Initial import of man functionality.
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/tbl.c

Initial import of man functionality.
175 lines changed: 175 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/tbl_data.c

Initial import of man functionality.
276 lines changed: 276 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/tbl_html.c

Initial import of man functionality.
151 lines changed: 151 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/tbl_layout.c

Initial import of man functionality.
472 lines changed: 472 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/tbl_opts.c

Initial import of man functionality.
270 lines changed: 270 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/tbl_term.c

Initial import of man functionality.
444 lines changed: 444 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/term.c

Initial import of man functionality.
736 lines changed: 736 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/term.h

Initial import of man functionality.
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/term_ascii.c

Initial import of man functionality.
289 lines changed: 289 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/term_ps.c

Initial import of man functionality.
1185 lines changed: 1185 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/tree.c

Initial import of man functionality.
349 lines changed: 349 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/vol.c

Initial import of man functionality.
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mandoc/vol.in

Initial import of man functionality.
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/Makefile

Finish integration.  Use mandoc_preconv, etc.
import complete (hopefully)
6 lines changed: 5 ins; 1 del; 0 mod; 749 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/apropos.1

import complete (hopefully)
142 lines changed: 0 ins; 64 del; 78 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/man.1

import complete (hopefully)
664 lines changed: 0 ins; 530 del; 134 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man1/mandoc.1

import complete (hopefully)
676 lines changed: 676 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/whatis.1

import complete (hopefully)
78 lines changed: 17 ins; 0 del; 61 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/Makefile

import complete (hopefully)
2 lines changed: 1 ins; 1 del; 0 mod; 820 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1m/catman.1m (deleted)

import complete (hopefully)
373 lines changed: 0 ins; 373 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/Makefile

import complete (hopefully)
6 lines changed: 5 ins; 0 del; 1 mod; 196 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/eqn.5

import complete (hopefully)
281 lines changed: 281 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/man.5

import complete (hopefully)
911 lines changed: 569 ins; 0 del; 342 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/mandoc_char.5

import complete (hopefully)
744 lines changed: 744 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/mandoc_roff.5

import complete (hopefully)
991 lines changed: 991 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/mdoc.5

import complete (hopefully)
3091 lines changed: 3091 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man5/tbl.5

import complete (hopefully)
349 lines changed: 349 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-man.mf

Finish integration.  Use mandoc_preconv, etc.
import complete (hopefully)
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/text-doctools.mf

Finish integration.  Use mandoc_preconv, etc.
import complete (hopefully)
25 lines changed: 2 ins; 22 del; 1 mod; 343 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.