Code Review for illumos

Prepared by:Garrett D'Amore (garrett) on 2015-Apr-06 11:47 -0700 PDT
Workspace:/work/garrett/illumos (at 762d96d8b217)
Compare against: master (at 309d9ad9da46)
Summary of changes: 374 lines changed: 361 ins; 6 del; 7 mod; 14690 unchg
Patch of changes: illumos.patch
Printable review: illumos.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/unistd.h

5798 fexecve() needed per POSIX 2008
3 lines changed: 3 ins; 0 del; 0 mod; 724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/amd64/Makefile

5798 fexecve() needed per POSIX 2008
3 lines changed: 2 ins; 1 del; 0 mod; 1229 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com

5798 fexecve() needed per POSIX 2008
2 lines changed: 1 ins; 0 del; 1 mod; 1303 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/llib-lc

5798 fexecve() needed per POSIX 2008
3 lines changed: 3 ins; 0 del; 0 mod; 1804 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers

5798 fexecve() needed per POSIX 2008
6 lines changed: 5 ins; 0 del; 1 mod; 3263 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/sys/fexecve.c

5798 fexecve() needed per POSIX 2008
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com

5798 fexecve() needed per POSIX 2008
2 lines changed: 1 ins; 0 del; 1 mod; 1381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparcv9/Makefile.com

5798 fexecve() needed per POSIX 2008
2 lines changed: 1 ins; 0 del; 1 mod; 1298 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libxcurses/h/mks.h

5798 fexecve() needed per POSIX 2008
7 lines changed: 2 ins; 5 del; 0 mod; 678 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man2/Makefile

5798 fexecve() needed per POSIX 2008
2 lines changed: 2 ins; 0 del; 0 mod; 414 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man2/exec.2
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

5798 fexecve() needed per POSIX 2008
Unexpected Error occurred reading `diff -e old/usr/src/man/man2/exec.2 new/usr/src/man/man2/exec.2`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-kernel.man2.inc

5798 fexecve() needed per POSIX 2008
2 lines changed: 2 ins; 0 del; 0 mod; 252 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-libctest.mf

5798 fexecve() needed per POSIX 2008
3 lines changed: 3 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/libc-tests/cfg/symbols/unistd_h.cfg

5798 fexecve() needed per POSIX 2008
5 lines changed: 5 ins; 0 del; 0 mod; 140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/libc-tests/runfiles/default.run

5798 fexecve() needed per POSIX 2008
3 lines changed: 2 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/libc-tests/tests/Makefile

5798 fexecve() needed per POSIX 2008
1 line changed: 0 ins; 0 del; 1 mod; 19 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/tests/fexecve/Makefile

5798 fexecve() needed per POSIX 2008
21 lines changed: 21 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/libc-tests/tests/fexecve/fexecve_test.c

5798 fexecve() needed per POSIX 2008
245 lines changed: 245 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/exec.c

5798 fexecve() needed per POSIX 2008
19 lines changed: 18 ins; 0 del; 1 mod; 2032 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.