Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-Feb-26 14:23 -0800 PST
Workspace:/ws/garrett/illumos-gate (at 9eb721cc17eb)
Compare against: master (at fb13f48f1d95)
Summary of changes: 703 lines changed: 6 ins; 665 del; 32 mod; 38256 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/Intro.9f

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
4 lines changed: 1 ins; 1 del; 2 mod; 865 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/Makefile

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
4 lines changed: 1 ins; 2 del; 1 mod; 1980 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/ddi_iomin.9f

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
9 lines changed: 1 ins; 2 del; 6 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/get_pktiopb.9f

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
2 lines changed: 0 ins; 0 del; 2 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/scsi_hba_attach_setup.9f

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
25 lines changed: 1 ins; 17 del; 7 mod; 291 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/scsi_slave.9f

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
2 lines changed: 0 ins; 0 del; 2 mod; 176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9s/Intro.9s

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
8 lines changed: 1 ins; 6 del; 1 mod; 187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9s/Makefile

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
6 lines changed: 0 ins; 6 del; 0 mod; 105 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man9s/ddi_dma_lim_sparc.9s (deleted)

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
129 lines changed: 0 ins; 129 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man9s/ddi_dma_lim_x86.9s (deleted)

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
148 lines changed: 0 ins; 148 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man9s/ddi_dma_req.9s (deleted)

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
222 lines changed: 0 ins; 222 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-kernel.man9s.inc

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
4 lines changed: 0 ins; 4 del; 0 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/pcic.c

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
4 lines changed: 0 ins; 2 del; 2 mod; 6866 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/impl/scsi_resource.c

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
2 lines changed: 0 ins; 2 del; 0 mod; 746 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/impl/scsi_subr.c

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
3 lines changed: 0 ins; 2 del; 1 mod; 2695 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/targets/st.c

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
3 lines changed: 0 ins; 2 del; 1 mod; 18591 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/warlock/ddi_dki_comm.inc

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
116 lines changed: 1 ins; 114 del; 1 mod; 198 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ddidmareq.h

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
3 lines changed: 0 ins; 1 del; 2 mod; 802 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/scsi/conf/device.h

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
3 lines changed: 0 ins; 3 del; 0 mod; 265 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sunddi.h

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
3 lines changed: 0 ins; 0 del; 3 mod; 2283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/dktp/dcdev/dadk.c

4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
3 lines changed: 0 ins; 2 del; 1 mod; 1839 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.