Code Review for illumos-gate

Prepared by:Garrett D'Amore (garrett) on 2014-Feb-26 09:49 -0800 PST
Workspace:/ws/garrett/illumos-gate (at 8864e9ddcf38)
Compare against: 97f7c4750238e3c507904468e4e9f17b15a08e2d (at 97f7c4750238)
Summary of changes: 535 lines changed: 370 ins; 86 del; 79 mod; 17172 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/driver-network-igb.mf

4431 igb support for I354
4616 igb has uninitialized kstats
4 lines changed: 4 ins; 0 del; 0 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_82575.c

4431 igb support for I354
4616 igb has uninitialized kstats
196 lines changed: 158 ins; 25 del; 13 mod; 3251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_82575.h

4431 igb support for I354
4616 igb has uninitialized kstats
2 lines changed: 2 ins; 0 del; 0 mod; 523 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_api.c

4431 igb support for I354
4616 igb has uninitialized kstats
6 lines changed: 6 ins; 0 del; 0 mod; 1353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_defines.h

4431 igb support for I354
4616 igb has uninitialized kstats
25 lines changed: 25 ins; 0 del; 0 mod; 1424 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_hw.h

4431 igb support for I354
4616 igb has uninitialized kstats
4 lines changed: 4 ins; 0 del; 0 mod; 1010 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_i210.c

4431 igb support for I354
4616 igb has uninitialized kstats
73 lines changed: 73 ins; 0 del; 0 mod; 754 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_i210.h

4431 igb support for I354
4616 igb has uninitialized kstats
4 lines changed: 4 ins; 0 del; 0 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/e1000api/e1000_regs.h

4431 igb support for I354
4616 igb has uninitialized kstats
10 lines changed: 10 ins; 0 del; 0 mod; 684 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/igb/igb_gld.c

4431 igb support for I354
4616 igb has uninitialized kstats
119 lines changed: 20 ins; 33 del; 66 mod; 1497 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/igb/igb_main.c

4431 igb support for I354
4616 igb has uninitialized kstats
32 lines changed: 32 ins; 0 del; 0 mod; 5325 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/igb/igb_stat.c

4431 igb support for I354
4616 igb has uninitialized kstats
7 lines changed: 3 ins; 4 del; 0 mod; 318 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/igb/igb_sw.h

4431 igb support for I354
4616 igb has uninitialized kstats
53 lines changed: 29 ins; 24 del; 0 mod; 850 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.