Code Review for illumos-gate

Prepared by: (estibi) on 2014-Oct-09 19:48 +0200 CEST
Workspace:/illumos-libm/illumos-gate (at 33621c02c739)
Compare against: libm_old_review (at e77d42eaa49f)
Summary of changes: 12653 lines changed: 12648 ins; 0 del; 5 mod; 2743 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

------ ------ ------ ------ ------ --- New Patch Raw usr/src/head/complex.h

patching complex.h - https://www.illumos.org/issues/3880
patch01 - 693 import Sun Devpro Math Library
patching complex.h - https://www.illumos.org/issues/3880
patch01 - 693 import Sun Devpro Math Library
134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/head/floatingpoint.h

patching floatingpoint.h - https://www.illumos.org/issues/3853
patch01 - 693 import Sun Devpro Math Library
patching floatingpoint.h - https://www.illumos.org/issues/3853
patch01 - 693 import Sun Devpro Math Library
212 lines changed: 212 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

remove noop change in lib/Makefile
patch01 - 693 import Sun Devpro Math Library
remove noop change in lib/Makefile
patch01 - 693 import Sun Devpro Math Library
18 lines changed: 14 ins; 0 del; 4 mod; 684 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/Makefile.com

remove -Wno-switch -Wno-parentheses -Wno-unused-variable from libm
remove -Wno-uninitialized for libm
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
remove -Wno-switch -Wno-parentheses -Wno-unused-variable from libm
#4625 add cscope.out to the .gitignore
remove -Wno-uninitialized for libm
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
1029 lines changed: 1029 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/amd64/src/libm_inlines.h

review fixes for libm/amd64/src/libm_inlines.h
fix tmpd in copysign()
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
review fixes for libm/amd64/src/libm_inlines.h
fix tmpd in copysign()
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
221 lines changed: 221 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/__tan.c

libm - cstyle fixes
__tan.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
libm - cstyle fixes
__tan.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
195 lines changed: 195 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/acos.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/acosh.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/asin.c

libm - more cstyle fixes
In case of |x| < 2**-27 we are talking about x being almost 0.
The graph of arcsine curve shows that arcsin(0) is 0 so we will return 0 if x == 0,
or return x and generate inexact if x is close to 0.
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
In case of |x| < 2**-27 we are talking about x being almost 0.
The graph of arcsine curve shows that arcsin(0) is 0 so we will return 0 if x == 0,
or return x and generate inexact if x is close to 0.
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
158 lines changed: 158 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/asinh.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/atanh.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/cosh.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/erf.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
427 lines changed: 427 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/expm1.c

libm - more cstyle fixes
common/C/expm1.c: cstyle
nextafter.c
log1p.c
It is safe to initialize c with 0 at the beginning.
We will use 'c' only if (k != 0).
libm/common/C/expm1.c
For |x| <= 0.5 ln2, (k == 0) we don't need to compute correction (c).
We can initialize c manually with 0, to fix compiler warning.
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
common/C/expm1.c: cstyle
nextafter.c
log1p.c
It is safe to initialize c with 0 at the beginning.
We will use 'c' only if (k != 0).
libm/common/C/expm1.c
For |x| <= 0.5 ln2, (k == 0) we don't need to compute correction (c).
We can initialize c manually with 0, to fix compiler warning.
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
266 lines changed: 266 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/fabs.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/j0.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
322 lines changed: 322 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/j1.c

libm - more cstyle fixes
common/C/j1.c: cstyle
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
common/C/j1.c: cstyle
patch01 - 693 import Sun Devpro Math Library
352 lines changed: 352 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/jn.c

libm - more cstyle fixes
common/C/jn.c: cstyle fixes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
common/C/jn.c: cstyle fixes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
306 lines changed: 306 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/matherr.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/sinh.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/C/tanh.c

libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - more cstyle fixes
patch01 - 693 import Sun Devpro Math Library
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/LD/__lgammal.c

libm - cstyle fixes
patch01 - 693 import Sun Devpro Math Library
libm - cstyle fixes
patch01 - 693 import Sun Devpro Math Library
402 lines changed: 402 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/LD/asinhl.c

fix lint warnings in LD/asinhl.c and LD/tanhl.c
asinhl.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
fix lint warnings in LD/asinhl.c and LD/tanhl.c
asinhl.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/LD/j0l.c

libm - cstyle fixes
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
libm - cstyle fixes
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
749 lines changed: 749 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/LD/j1l.c

libm - cstyle fixes
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
libm - cstyle fixes
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
753 lines changed: 753 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/LD/jnl.c

common/LD/jnl.c: cstyle fixes
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
common/LD/jnl.c: cstyle fixes
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
285 lines changed: 285 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/LD/tanhl.c

fix lint warnings in LD/asinhl.c and LD/tanhl.c
libm/common/R/tanf.c
libm/common/R/sinf.c
libm/common/R/sincosf.c
libm/common/R/cosf.c
libm/common/Q/tanhl.c
libm/common/Q/asinl.c
libm/common/Q/asinhl.c
tanhl.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
fix lint warnings in LD/asinhl.c and LD/tanhl.c
libm/common/R/tanf.c
libm/common/R/sinf.c
libm/common/R/sincosf.c
libm/common/R/cosf.c
libm/common/Q/tanhl.c
libm/common/Q/asinl.c
libm/common/Q/asinhl.c
tanhl.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/m9x/fenv_inlines.h

fixes for %1 +x in common/m9x/fenv_inlines.h
fix fsincos in common/m9x/fenv_inlines.h
patch05 - fixed amd64 issues with LIBM
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
fixes for %1 +x in common/m9x/fenv_inlines.h
fix fsincos in common/m9x/fenv_inlines.h
patch05 - fixed amd64 issues with LIBM
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
687 lines changed: 687 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/m9x/nearbyint.c

remove unused code from common/m9x/nearbyint.c
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch05 - fixed amd64 issues with LIBM
patch01 - 693 import Sun Devpro Math Library
remove unused code from common/m9x/nearbyint.c
minor changes
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch05 - fixed amd64 issues with LIBM
patch01 - 693 import Sun Devpro Math Library
122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/common/m9x/scalblnl.c

remove -Wno-switch -Wno-parentheses -Wno-unused-variable from libm
rollback ISINFNANL in libm/common/m9x/scalblnl.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
remove -Wno-switch -Wno-parentheses -Wno-unused-variable from libm
rollback ISINFNANL in libm/common/m9x/scalblnl.c
patch07 - removed dead code with mtsk.h
patch06 - libm: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/i386/src/libm_inlines.h

libm/i386/src/libm_inlines.h - ceil()
libm/i386/src/libm_inlines.h use xorl %0, %0 to get a 0
i386/src/libm_inlines.h isnan() was missing
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
libm/i386/src/libm_inlines.h - ceil()
libm/i386/src/libm_inlines.h use xorl %0, %0 to get a 0
i386/src/libm_inlines.h isnan() was missing
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
351 lines changed: 351 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/sparc/src/libm_inlines.h

libm/sparc/src/libm_inlines.h - __swapTE()
libm/sparc/src/libm_inlines.h - __swapEX()
libm/sparc/src/libm_inlines.h - fixes part 1
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
libm/sparc/src/libm_inlines.h - fixes part 1
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
301 lines changed: 301 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libm/sparcv9/src/libm_inlines.h

libm/sparcv9/src/libm_inlines.h - fabss/fabsd register should be listed as read write
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
298 lines changed: 298 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmvec/Makefile.com

libmvec - remove -Wno-parentheses and -Wno-unused-variable
comment in tgamma*.c
libm/common/m9x/tgamma.c
remove -Wno-uninitialized in libmvec
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
comment in tgamma*.c
libm/common/m9x/tgamma.c
remove -Wno-uninitialized in libmvec
libm fixes from richlowe - richlowe.net/webrevs/il_keith
patch01 - 693 import Sun Devpro Math Library
296 lines changed: 296 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmvec/common/__vcos.c

Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED
patch12 - math.h: Align things with GCC
patch11 - added LIBM man pages
patch09 - update libmvec: fix build issues by gcc46
patch08 - libmvec: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED
patch12 - math.h: Align things with GCC
patch11 - added LIBM man pages
patch09 - update libmvec: fix build issues by gcc46
patch08 - libmvec: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
1100 lines changed: 1100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmvec/common/__vsin.c

Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED
patch12 - math.h: Align things with GCC
patch11 - added LIBM man pages
patch09 - update libmvec: fix build issues by gcc46
patch08 - libmvec: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED
patch12 - math.h: Align things with GCC
patch11 - added LIBM man pages
patch09 - update libmvec: fix build issues by gcc46
patch08 - libmvec: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
1108 lines changed: 1108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libmvec/common/__vsincos.c

Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED
patch12 - math.h: Align things with GCC
patch11 - added LIBM man pages
patch09 - update libmvec: fix build issues by gcc46
patch08 - libmvec: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED
patch12 - math.h: Align things with GCC
patch11 - added LIBM man pages
patch09 - update libmvec: fix build issues by gcc46
patch08 - libmvec: fixed compilation issues after updates
patch01 - 693 import Sun Devpro Math Library
1547 lines changed: 1547 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.c

rollback tools/cw/cw.c
patch01 - 693 import Sun Devpro Math Library
rollback tools/cw/cw.c
patch01 - 693 import Sun Devpro Math Library
6 lines changed: 5 ins; 0 del; 1 mod; 1912 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ccompile.h

Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED - fix cstyle
fix for patch09 - use __GNU_UNUSED
Revert "remove unused v from libmvec"
This reverts commit e853d278ee4b7f2a8c2117cc598cfc68b4e3f29b.
fix system-library-math.mf
update libm manifests
14071:dece9aafe99a - fix build problems on sparc
remove unused v from libmvec
fix for patch09 - use __GNU_UNUSED - fix cstyle
fix for patch09 - use __GNU_UNUSED
1 line changed: 1 ins; 0 del; 0 mod; 147 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.