Code Review for gsoc

Prepared by: (sunkiss) on 2012-Jun-12 19:55 +0200 CEST
Workspace:/mnt/gsoc (at a47e8e57b77a)
Compare against: origin/master (/net/wpa-enterprise/ at 7d7551bcfe5d)
Summary of changes: 3432 lines changed: 2371 ins; 699 del; 362 mod; 43170 unchg
Patch of changes: gsoc.patch
Printable review: gsoc.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/packaging

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
2 lines changed: 0 ins; 2 del; 0 mod; 956 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.lint

wpa_supplicant pkg now is created correctly in illumos-gate
wpad renamed to wpa_supplicant
1 line changed: 0 ins; 1 del; 0 mod; 520 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile.check

wpa_supplicant pkg now is created correctly in illumos-gate
wpad renamed to wpa_supplicant
1 line changed: 0 ins; 0 del; 1 mod; 174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/lib/nwamd/known_wlans.c

secobjs types now are "wep, psk, eap, pin"
dladm_wlan_secmode_t and dladm_secobj_class_t are not related anymore
2 lines changed: 0 ins; 0 del; 2 mod; 550 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/lib/nwamd/ncu_phys.c

secobjs types now are "wep, psk, eap, pin"
dladm_wlan_secmode_t and dladm_secobj_class_t are not related anymore
16 lines changed: 7 ins; 1 del; 8 mod; 1906 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/Makefile

wpa_supplicant pkg now is created correctly in illumos-gate
wpad renamed to wpa_supplicant
1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wpa_supplicant/Makefile

wpa_supplicant pkg now is created correctly in illumos-gate
wpad renamed to wpa_supplicant
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wpa_supplicant/wpa_supplicant.xml

wpa_supplicant pkg now is created correctly in illumos-gate
wpad renamed to wpa_supplicant
130 lines changed: 130 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-inet/usr.lib/wpa_supplicant/wpa_supplicant/Makefile

wpa_supplicant pkg now is created correctly in illumos-gate
wpad renamed to wpa_supplicant
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/Makefile

removed wificonfig tool
are /dev/wifi/* devices links now deprecated?
4 lines changed: 0 ins; 1 del; 3 mod; 271 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dladm/dladm.c

removed wpa.h header file
updated wpa_supplicant manifest to use global ctrl interface
some changes to libdlwlan, i need to finish ctrl_if integration
38 lines changed: 13 ins; 17 del; 8 mod; 9665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/milestone/net-physical

removed wificonfig tool
are /dev/wifi/* devices links now deprecated?
11 lines changed: 0 ins; 11 del; 0 mod; 534 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/milestone/network-physical.xml

removed wpa.h header file
updated wpa_supplicant manifest to use global ctrl interface
some changes to libdlwlan, i need to finish ctrl_if integration
14 lines changed: 14 ins; 0 del; 0 mod; 174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/Makefile

Fixed minor compile errors
3 lines changed: 0 ins; 0 del; 3 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/Makefile.com

Fixed minor compile errors
2 lines changed: 0 ins; 0 del; 2 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdladm.h

moved dladm_secobj_class_t to libdladm
8 lines changed: 8 ins; 0 del; 0 mod; 294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdllink.h

secobjs types now are "wep, psk, eap, pin"
dladm_wlan_secmode_t and dladm_secobj_class_t are not related anymore
4 lines changed: 0 ins; 4 del; 0 mod; 223 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlwlan.c

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
879 lines changed: 210 ins; 454 del; 215 mod; 1310 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlwlan.h

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
250 lines changed: 146 ins; 28 del; 76 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlwlan_impl.h

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
12 lines changed: 12 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/linkprop.c

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
4 lines changed: 0 ins; 4 del; 0 mod; 4581 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/mapfile-vers

cleaned lint warnings
9 lines changed: 8 ins; 1 del; 0 mod; 274 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/secobj.c

secobjs types now are "wep, psk, eap, pin"
dladm_wlan_secmode_t and dladm_secobj_class_t are not related anymore
5 lines changed: 3 ins; 0 del; 2 mod; 662 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/wpa_ie.c

secobjs types now are "wep, psk, eap, pin"
dladm_wlan_secmode_t and dladm_secobj_class_t are not related anymore
670 lines changed: 670 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/wpa_if.c

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
821 lines changed: 821 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnwam/common/libnwam_known_wlan.c

Implemented ctrl_if network block configuration routine
2 lines changed: 1 ins; 0 del; 1 mod; 854 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnwam/common/libnwam_values.c

Implemented ctrl_if network block configuration routine
2 lines changed: 1 ins; 0 del; 1 mod; 1142 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsecdb/auth_attr.txt

removed wificonfig tool
are /dev/wifi/* devices links now deprecated?
2 lines changed: 0 ins; 2 del; 0 mod; 211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsecdb/help/auths/Makefile

removed wificonfig tool
are /dev/wifi/* devices links now deprecated?
2 lines changed: 0 ins; 2 del; 0 mod; 207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.mf

removed wificonfig tool
are /dev/wifi/* devices links now deprecated?
2 lines changed: 0 ins; 2 del; 0 mod; 1907 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/consolidation-osnet-osnet-message-files.mf

removed wificonfig tool
are /dev/wifi/* devices links now deprecated?
2 lines changed: 0 ins; 2 del; 0 mod; 451 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/service-network-wpa_supplicant.mf

wpa_supplicant pkg now is created correctly in illumos-gate
wpad renamed to wpa_supplicant
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/wifi_ioctl.h

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
105 lines changed: 81 ins; 2 del; 22 mod; 372 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/dld/dld_drv.c

secobjs types now are "wep, psk, eap, pin"
dladm_wlan_secmode_t and dladm_secobj_class_t are not related anymore
2 lines changed: 0 ins; 1 del; 1 mod; 1511 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/mac/mac.c

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
4 lines changed: 0 ins; 4 del; 0 mod; 7885 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/net80211/net80211.c

updated libdladm public interface
prevented usr.lib/wpa_supplicant from being checked with lint
3 lines changed: 0 ins; 3 del; 0 mod; 866 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/net80211/net80211_ioctl.c

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
186 lines changed: 20 ins; 155 del; 11 mod; 2388 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/net/Makefile

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/dld.h

secobjs types now are "wep, psk, eap, pin"
dladm_wlan_secmode_t and dladm_secobj_class_t are not related anymore
9 lines changed: 7 ins; 0 del; 2 mod; 431 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/mac.h

Fixed minor compile errors
1 line changed: 0 ins; 1 del; 0 mod; 651 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/net80211.h

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
25 lines changed: 23 ins; 1 del; 1 mod; 748 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/net80211_proto.h

ess_list ioctl now provides all scan results properties for wpa/libdlwlan
first integration of wpa_s control interface client code
first integration of wpa_s wpa_ie parsing code
1 line changed: 0 ins; 0 del; 1 mod; 977 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.