Print this page
3011 OPENSSL10_ONLY is evaluated over and over
Reviewed by: Jonathan Adams <t12nslookup@gmail.com>
Reviewed by: Gary Mills <gary_mills@fastmail.fm>
Reviewed by: Richard Lowe <richlowe@richlowe.net>
Reviewed by: Garrett D'Amore <garrett@damore.org>

Split Close
Expand all
Collapse all
          --- old/usr/src/pkg/Makefile
          +++ new/usr/src/pkg/Makefile
↓ open down ↓ 144 lines elided ↑ open up ↑
 145  145  #
 146  146  # We can't simply use $(MACH32) and $(MACH64) here, because they're
 147  147  # only defined for the build architecture.  To do cross-platform
 148  148  # packaging, we need both values.
 149  149  #
 150  150  i386_ARCH32= i86
 151  151  sparc_ARCH32= sparcv7
 152  152  i386_ARCH64= amd64
 153  153  sparc_ARCH64= sparcv9
 154  154  
 155      -OPENSSL =       /usr/bin/openssl
 156      -OPENSSL10.cmd = $(OPENSSL) version | $(NAWK) '{if($$2<1){print "\043";}}'
 157      -OPENSSL10_ONLY  =       $(OPENSSL10.cmd:sh)
      155 +# The form "MACRO :sh= COMMAND" ensures that the COMMAND is executed only once,
      156 +# whereas with the form "MACRO = $(COMMAND:sh)" the COMMAND is executed
      157 +# whenever the reference is evaluated.
      158 +#
      159 +# The form "MACRO :sh= COMMAND" does not substitue macros in COMMAND, so macros
      160 +# defined in Makefile.master is not used here.
      161 +OPENSSL10_ONLY :sh= /usr/bin/openssl version | \
      162 +        /usr/bin/nawk '{if($2<1){print "\043";}}'
 158  163  
 159  164  #
 160  165  # macros and transforms needed by pkgmogrify
 161  166  #
 162  167  # If you append to this list using target-specific assignments (:=),
 163  168  # be very careful that the targets are of the form $(PDIR)/pkgname.  If
 164  169  # you use a higher level target, or a package list, you'll trigger a
 165  170  # complete reprocessing of all manifests because they'll fail command
 166  171  # dependency checking.
 167  172  #
↓ open down ↓ 578 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX