Print this page 
3956 ::vdev -r should work with pipelines
3957 ztest should update the cachefile before killing itself
3958 multiple scans can lead to partial resilvering
3959 ddt entries are not always resilvered
3960 dsl_scan can skip over dedup-ed blocks if physical birth != logical birth
3961 freed gang blocks are not resilvered and can cause pool to suspend
3962 ztest should print out zfs debug buffer before exiting
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Adam Leventhal <ahl@delphix.com>
Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/fs/zfs/sys/dsl_scan.h
          +++ new/usr/src/uts/common/fs/zfs/sys/dsl_scan.h
↓ open down ↓ 64 lines elided ↑ open up ↑ 
  65   65          zbookmark_t scn_bookmark;
  66   66          uint64_t scn_flags; /* dsl_scan_flags_t */
  67   67  } dsl_scan_phys_t;
  68   68  
  69   69  #define SCAN_PHYS_NUMINTS (sizeof (dsl_scan_phys_t) / sizeof (uint64_t))
  70   70  
  71   71  typedef enum dsl_scan_flags {
  72   72          DSF_VISIT_DS_AGAIN = 1<<0,
  73   73  } dsl_scan_flags_t;
  74   74  
       75 +/*
       76 + * Every pool will have one dsl_scan_t and this structure will contain
       77 + * in-memory information about the scan and a pointer to the on-disk
       78 + * representation (i.e. dsl_scan_phys_t). Most of the state of the scan
       79 + * is contained on-disk to allow the scan to resume in the event of a reboot
       80 + * or panic. This structure maintains information about the behavior of a
       81 + * running scan, some caching information, and how it should traverse the pool.
       82 + *
       83 + * The following members of this structure direct the behavior of the scan:
       84 + *
       85 + * scn_pausing -        a scan that cannot be completed in a single txg or
       86 + *                      has exceeded its allotted time will need to pause.
       87 + *                      When this flag is set the scanner will stop traversing
       88 + *                      the pool and write out the current state to disk.
       89 + *
       90 + * scn_restart_txg -    directs the scanner to either restart or start a
       91 + *                      a scan at the specified txg value.
       92 + *
       93 + * scn_done_txg -       when a scan completes its traversal it will set
       94 + *                      the completion txg to the next txg. This is necessary
       95 + *                      to ensure that any blocks that were freed during
       96 + *                      the scan but have not yet been processed (i.e deferred
       97 + *                      frees) are accounted for.
       98 + *
       99 + * This structure also maintains information about deferred frees which are
      100 + * a special kind of traversal. Deferred free can exist in either a bptree or
      101 + * a bpobj structure. The scn_is_bptree flag will indicate the type of
      102 + * deferred free that is in progress. If the deferred free is part of an
      103 + * asynchronous destroy then the scn_async_destroying flag will be set.
      104 + */
  75  105  typedef struct dsl_scan {
  76  106          struct dsl_pool *scn_dp;
  77  107  
  78  108          boolean_t scn_pausing;
  79  109          uint64_t scn_restart_txg;
      110 +        uint64_t scn_done_txg;
  80  111          uint64_t scn_sync_start_time;
  81  112          zio_t *scn_zio_root;
  82  113  
  83  114          /* for freeing blocks */
  84  115          boolean_t scn_is_bptree;
  85  116          boolean_t scn_async_destroying;
  86  117  
  87  118          /* for debugging / information */
  88  119          uint64_t scn_visited_this_txg;
  89  120
↓ open down ↓ 24 lines elided ↑ open up ↑ 
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX