Code Review for illumos-gate

Prepared by:Super-User (root) on 2017-Nov-06 02:54 +0000 GMT
Workspace:/root/illumos-gate (at 850fffadd91a)
Compare against: origin/master (git@github.com:illumos/illumos-gate.git at 4831c99d5b55)
Summary of changes: 2965 lines changed: 1267 ins; 1406 del; 292 mod; 56545 unchg
Patch of changes: illumos-gate.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/packaging

8115 parallel zfs mount
16 lines changed: 8 ins; 7 del; 1 mod; 994 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Targetdirs

8115 parallel zfs mount
12 lines changed: 11 ins; 1 del; 0 mod; 1879 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/intel/amd64/libzpool/Makefile

8115 parallel zfs mount
3 lines changed: 3 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/intel/ia32/libzpool/Makefile

8115 parallel zfs mount
2 lines changed: 2 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zdb/Makefile.com

8115 parallel zfs mount
3 lines changed: 2 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zdb/zdb.c

8115 parallel zfs mount
2 lines changed: 2 ins; 0 del; 0 mod; 4150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zfs/zfs_main.c

8115 parallel zfs mount
95 lines changed: 57 ins; 10 del; 28 mod; 7257 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zhack/Makefile.com

8115 parallel zfs mount
2 lines changed: 2 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zinject/Makefile.com

8115 parallel zfs mount
2 lines changed: 2 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ztest/Makefile.com

8115 parallel zfs mount
3 lines changed: 2 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ztest/ztest.c

8115 parallel zfs mount
122 lines changed: 1 ins; 0 del; 121 mod; 6301 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/Makefile.com

8115 parallel zfs mount
6 lines changed: 6 ins; 0 del; 0 mod; 75 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libfakekernel/common/buf.c

8115 parallel zfs mount
77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/cond.c

8115 parallel zfs mount
14 lines changed: 14 ins; 0 del; 0 mod; 180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/cred.c

8115 parallel zfs mount
29 lines changed: 29 ins; 0 del; 0 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/kmem.c

8115 parallel zfs mount
25 lines changed: 25 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/kmisc.c

8115 parallel zfs mount
74 lines changed: 74 ins; 0 del; 0 mod; 81 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libfakekernel/common/ksid.c

8115 parallel zfs mount
68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/kstat.c

8115 parallel zfs mount
36 lines changed: 36 ins; 0 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/mapfile-vers

8115 parallel zfs mount
46 lines changed: 44 ins; 2 del; 0 mod; 193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/mutex.c

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/printf.c

8115 parallel zfs mount
11 lines changed: 11 ins; 0 del; 0 mod; 154 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libfakekernel/common/sys/cmn_err.h

8115 parallel zfs mount
80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/sys/condvar.h

8115 parallel zfs mount
5 lines changed: 5 ins; 0 del; 0 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/sys/cred.h

8115 parallel zfs mount
4 lines changed: 4 ins; 0 del; 0 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/sys/mutex.h

8115 parallel zfs mount
14 lines changed: 12 ins; 1 del; 1 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/sys/proc.h

8115 parallel zfs mount
13 lines changed: 13 ins; 0 del; 0 mod; 125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/taskq.c

8115 parallel zfs mount
13 lines changed: 13 ins; 0 del; 0 mod; 380 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfakekernel/common/thread.c

8115 parallel zfs mount
27 lines changed: 27 ins; 0 del; 0 mod; 125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/Makefile.com

8115 parallel zfs mount
5 lines changed: 3 ins; 0 del; 2 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs.h

8115 parallel zfs mount
6 lines changed: 2 ins; 3 del; 1 mod; 813 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_dataset.c

8115 parallel zfs mount
23 lines changed: 10 ins; 1 del; 12 mod; 4940 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_impl.h

8115 parallel zfs mount
9 lines changed: 8 ins; 0 del; 1 mod; 217 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_mount.c

8115 parallel zfs mount
348 lines changed: 272 ins; 16 del; 60 mod; 1304 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/mapfile-vers

8115 parallel zfs mount
3 lines changed: 1 ins; 1 del; 1 mod; 262 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/Makefile.com

8115 parallel zfs mount
8 lines changed: 5 ins; 0 del; 3 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/common/kernel.c

8115 parallel zfs mount
630 lines changed: 4 ins; 625 del; 1 mod; 536 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/common/sys/zfs_context.h

8115 parallel zfs mount
414 lines changed: 22 ins; 389 del; 3 mod; 308 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libzpool/common/taskq.c (deleted)

8115 parallel zfs mount
342 lines changed: 0 ins; 342 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/common/util.c

8115 parallel zfs mount
3 lines changed: 3 ins; 0 del; 0 mod; 187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.mf

8115 parallel zfs mount
6 lines changed: 6 ins; 0 del; 0 mod; 1323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-zfstest.mf

8115 parallel zfs mount
5 lines changed: 5 ins; 0 del; 0 mod; 2548 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/zfs-tests/runfiles/delphix.run

8115 parallel zfs mount
1 line changed: 0 ins; 0 del; 1 mod; 580 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/zfs-tests/tests/functional/cli_root/zfs_mount/zfs_mount.kshlib

8115 parallel zfs mount
5 lines changed: 0 ins; 2 del; 3 mod; 130 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/zfs-tests/tests/functional/cli_root/zfs_mount/zfs_mount_all_fail.ksh

8115 parallel zfs mount
96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/zfs-tests/tests/functional/cli_root/zfs_mount/zfs_mount_all_mountpoints.ksh

8115 parallel zfs mount
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/hsfs/hsfs_vfsops.c

8115 parallel zfs mount
2 lines changed: 1 ins; 0 del; 1 mod; 1563 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/pcfs/pc_vfsops.c

8115 parallel zfs mount
4 lines changed: 3 ins; 0 del; 1 mod; 2714 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/udfs/udf_vfsops.c

8115 parallel zfs mount
11 lines changed: 1 ins; 2 del; 8 mod; 1938 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/ufs/ufs_vfsops.c

8115 parallel zfs mount
5 lines changed: 1 ins; 1 del; 3 mod; 2100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/vfs.c

8115 parallel zfs mount
5 lines changed: 2 ins; 0 del; 3 mod; 4771 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dnode.c

8115 parallel zfs mount
7 lines changed: 6 ins; 1 del; 0 mod; 1992 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/acl.h

8115 parallel zfs mount
2 lines changed: 1 ins; 0 del; 1 mod; 319 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/bitmap.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/bitset.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/buf.h

8115 parallel zfs mount
4 lines changed: 2 ins; 0 del; 2 mod; 404 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/cpupart.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 155 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/cpuvar.h

8115 parallel zfs mount
5 lines changed: 2 ins; 0 del; 3 mod; 829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/cyclic.h

8115 parallel zfs mount
4 lines changed: 2 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/fm/util.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/kobj.h

8115 parallel zfs mount
6 lines changed: 2 ins; 2 del; 2 mod; 207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/lgrp.h

8115 parallel zfs mount
6 lines changed: 2 ins; 0 del; 4 mod; 636 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/lgrp_user.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 292 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/systeminfo.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/taskq.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/taskq_impl.h

8115 parallel zfs mount
2 lines changed: 2 ins; 0 del; 0 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/vfs.h

8115 parallel zfs mount
2 lines changed: 1 ins; 0 del; 1 mod; 613 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kmem.h

8115 parallel zfs mount
3 lines changed: 1 ins; 0 del; 2 mod; 146 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.