Code Review for illumos-gate-4833

Prepared by:Andrew (andy) on 2014-Apr-22 07:25 +0100 BST
Workspace:/home/andy/Projects/illumos-gate-4833 (at 84f29ab34b5f)
Compare against: 5539384561c0efe744226d5e5d331f5546e500e4 (at 5539384561c0)
Summary of changes: 469 lines changed: 18 ins; 417 del; 34 mod; 9109 unchg
Patch of changes: illumos-gate-4833.patch
Printable review: illumos-gate-4833.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
3 lines changed: 1 ins; 2 del; 0 mod; 838 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmformat/Makefile

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
4 lines changed: 2 ins; 2 del; 0 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmformat/rmf_menu.c

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
6 lines changed: 2 ins; 0 del; 4 mod; 1205 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmformat/rmf_misc.c

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
15 lines changed: 2 ins; 1 del; 12 mod; 2078 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmformat/rmf_slice.c

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
5 lines changed: 2 ins; 0 del; 3 mod; 1667 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmvolmgr/vold.c

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
5 lines changed: 2 ins; 1 del; 2 mod; 1083 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmvolmgr/vold.h

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
7 lines changed: 2 ins; 3 del; 2 mod; 68 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/volrmmount/Makefile (deleted)

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
71 lines changed: 0 ins; 71 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/volrmmount/volrmmount.c (deleted)

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
151 lines changed: 0 ins; 151 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/Makefile

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
2 lines changed: 1 ins; 1 del; 0 mod; 750 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/fdformat.1

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
4 lines changed: 1 ins; 0 del; 3 mod; 467 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/rmformat.1

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
6 lines changed: 1 ins; 0 del; 5 mod; 536 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/man/man1/volrmmount.1 (deleted)

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
183 lines changed: 0 ins; 183 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/rmmount.1m

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
4 lines changed: 1 ins; 0 del; 3 mod; 285 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-storage-media-volume-manager.mf

4833 Remove volrmmount
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
3 lines changed: 1 ins; 2 del; 0 mod; 66 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.