| Prepared by: | Andrew (andy) on 2013-Sep-09 17:56 +0100 BST |
|---|---|
| Workspace: | /home/andy/Projects/illumos-gate-4078 (at 0ae59ab360c4) |
| Compare against: | 20aa1b4d581d4b759a9db7f61e4ab39b88dcb9c4 (at 20aa1b4d581d) |
| Summary of changes: | 321 lines changed: 111 ins; 138 del; 72 mod; 7872 unchg |
| Patch of changes: | illumos-gate-4078.patch |
| Printable review: | illumos-gate-4078.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Targetdirs
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>2 lines changed: 2 ins; 0 del; 0 mod; 1947 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/group/Makefile
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>5 lines changed: 2 ins; 1 del; 2 mod; 79 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libcmdutils/common/gid.c (renamed and modified from usr/src/cmd/oamuser/group/gid.c)
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>109 lines changed: 46 ins; 44 del; 19 mod; 46 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/group/groupadd.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>7 lines changed: 3 ins; 1 del; 3 mod; 146 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/Makefile
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>12 lines changed: 2 ins; 3 del; 7 mod; 108 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/funcs.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>4 lines changed: 2 ins; 0 del; 2 mod; 514 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/useradd.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>9 lines changed: 4 ins; 1 del; 4 mod; 750 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/userdefs.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>4 lines changed: 1 ins; 0 del; 3 mod; 428 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/usermod.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>5 lines changed: 3 ins; 0 del; 2 mod; 673 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/val_lgrp.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>5 lines changed: 4 ins; 0 del; 1 mod; 116 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/oamuser/user/val_lprj.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>4 lines changed: 2 ins; 0 del; 2 mod; 104 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libcmdutils/Makefile.com
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>2 lines changed: 1 ins; 0 del; 1 mod; 62 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libcmdutils/common/mapfile-vers
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>3 lines changed: 3 ins; 0 del; 0 mod; 71 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libcmdutils/common/uid.c (renamed and modified from usr/src/cmd/oamuser/user/uid.c)
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>63 lines changed: 17 ins; 23 del; 23 mod; 72 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libcmdutils/libcmdutils.h
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>17 lines changed: 17 ins; 0 del; 0 mod; 132 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libsmb/common/smb_lgrp.c
4078 groupadd execs getent unnecessarily Reviewed by: Rich Lowe <richlowe@richlowe.net> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Milan Jurik <milan.jurik@xylab.cz> Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>70 lines changed: 2 ins; 65 del; 3 mod; 2624 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.