Code Review for illumos-gate-3900

Prepared by:Andrew (andy) on 2014-Jan-29 21:01 +0000 GMT
Workspace:/home/andy/Projects/illumos-gate-3900 (at a56881f13bf2)
Compare against: a11c1571b6942161b0186d0588609448066892c2 (at a11c1571b694)
Summary of changes: 2670 lines changed: 57 ins; 2588 del; 25 mod; 4454 unchg
Patch of changes: illumos-gate-3900.patch
Printable review: illumos-gate-3900.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/Catalog/Catalog.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/Catalog/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/Exacct.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/File/File.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/File/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/Object/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Exacct/Object/Object.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Intrs/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Lgrp/Lgrp.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Lgrp/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/PerlGcc/MANIFEST

3900 illumos will not build against gcc compiled perl
2 lines changed: 0 ins; 2 del; 0 mod; 5 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/PerlGcc/Makefile.PL

3900 illumos will not build against gcc compiled perl
43 lines changed: 38 ins; 2 del; 3 mod; 96 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/perl/contrib/Sun/Solaris/PerlGcc/config/5.8.4/5.11/i386/Config.pm (deleted)

3900 illumos will not build against gcc compiled perl
1292 lines changed: 0 ins; 1292 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/perl/contrib/Sun/Solaris/PerlGcc/config/5.8.4/5.11/sparc/Config.pm (deleted)

3900 illumos will not build against gcc compiled perl
1292 lines changed: 0 ins; 1292 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Pg/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Privilege/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Privilege/Privilege.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Project/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Project/Project.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 1912 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Task/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Task/Task.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 27 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Ucred/Makefile.PL

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/contrib/Sun/Solaris/Ucred/Ucred.pm

3900 illumos will not build against gcc compiled perl
1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/perl/skel/Makefile

3900 illumos will not build against gcc compiled perl
20 lines changed: 18 ins; 0 del; 2 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/runtime-perl-510-module-sun-solaris.mf

3900 illumos will not build against gcc compiled perl
1 line changed: 1 ins; 0 del; 0 mod; 155 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.