Print this page
4853 illumos-gate is not lint-clean when built with openssl 1.0 (fix openssl 0.9.8 lint)

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/cmd-inet/usr.lib/wanboot/wanboot-cgi/wanboot-cgi.c
          +++ new/usr/src/cmd/cmd-inet/usr.lib/wanboot/wanboot-cgi/wanboot-cgi.c
↓ open down ↓ 869 lines elided ↑ open up ↑
 870  870                  errtype = 1;
 871  871                  goto cleanup;
 872  872          }
 873  873          PKCS12_free(p12);
 874  874          p12 = NULL;
 875  875  
 876  876          /*
 877  877           * Merge the two stacks of pkcs12 certs.
 878  878           */
 879  879          for (i = 0; i < sk_X509_num(i_anchors); i++) {
      880 +                /* LINTED */
 880  881                  x = sk_X509_delete(i_anchors, i);
 881  882                  (void) sk_X509_push(o_anchors, x);
 882  883          }
 883  884  
 884  885          /*
 885  886           * Create the pkcs12 structure from the modified input stack and
 886  887           * then write out that structure.
 887  888           */
 888  889          p12 = sunw_PKCS12_create((const char *)WANBOOT_PASSPHRASE, NULL, NULL,
 889  890              o_anchors);
↓ open down ↓ 192 lines elided ↑ open up ↑
1082 1083              NULL, NULL, &certs);
1083 1084          if (i <= 0) {
1084 1085                  errtype = 1;
1085 1086                  goto cleanup;
1086 1087          }
1087 1088  
1088 1089          PKCS12_free(p12);
1089 1090          p12 = NULL;
1090 1091  
1091 1092          for (i = 0; i < sk_X509_num(certs); i++) {
     1093 +                /* LINTED */
1092 1094                  x = sk_X509_value(certs, i);
1093 1095                  if (!one_name(sunw_issuer_attrs(x, buf, sizeof (buf) - 1),
1094 1096                      nvl)) {
1095 1097                          goto cleanup;
1096 1098                  }
1097 1099          }
1098 1100  
1099 1101          ret = WBCGI_FTW_CBCONT;
1100 1102  cleanup:
1101 1103          if (ret == WBCGI_FTW_CBERR) {
↓ open down ↓ 800 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX