Print this page
4853 illumos-gate is not lint-clean when built with openssl 1.0

Split Close
Expand all
Collapse all
          --- old/usr/src/lib/openssl/libsunw_crypto/x509v3/v3_utl.c
          +++ new/usr/src/lib/openssl/libsunw_crypto/x509v3/v3_utl.c
↓ open down ↓ 357 lines elided ↑ open up ↑
 358  358  /* Given a buffer of length 'len' return a OPENSSL_malloc'ed string with its
 359  359   * hex representation
 360  360   * @@@ (Contents of buffer are always kept in ASCII, also on EBCDIC machines)
 361  361   */
 362  362  
 363  363  char *hex_to_string(const unsigned char *buffer, long len)
 364  364  {
 365  365          char *tmp, *q;
 366  366          const unsigned char *p;
 367  367          int i;
 368      -        const static char hexdig[] = "0123456789ABCDEF";
      368 +        static const char hexdig[] = "0123456789ABCDEF";
 369  369          if(!buffer || !len) return NULL;
 370  370          if(!(tmp = OPENSSL_malloc(len * 3 + 1))) {
 371  371                  X509V3err(X509V3_F_HEX_TO_STRING,ERR_R_MALLOC_FAILURE);
 372  372                  return NULL;
 373  373          }
 374  374          q = tmp;
 375  375          for(i = 0, p = buffer; i < len; i++,p++) {
 376  376                  *q++ = hexdig[(*p >> 4) & 0xf];
 377  377                  *q++ = hexdig[*p & 0xf];
 378  378                  *q++ = ':';
↓ open down ↓ 496 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX