Code Review for illumos-gate

Prepared by:Alexander Pyhalov (alp) on 2014-Sep-22 12:11 +0400 MSK
Workspace:/home/alp/srcs/illumos-gate (at a82f6cf1e195)
Compare against: master (at 32ce6b819524)
Summary of changes: 1098 lines changed: 1071 ins; 11 del; 16 mod; 7268 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.lint

5166 sendmail package should be replaceable
1 line changed: 1 ins; 0 del; 0 mod; 523 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile

5166 sendmail package should be replaceable
1 line changed: 1 ins; 0 del; 0 mod; 839 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/notify/smtp-notify/common/smtp-notify.xml

5166 sendmail package should be replaceable
1 line changed: 0 ins; 1 del; 0 mod; 141 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/Makefile

5166 sendmail package should be replaceable
110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/THIRDPARTYLICENSE

5166 sendmail package should be replaceable
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/THIRDPARTYLICENSE.descrip

5166 sendmail package should be replaceable
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/compat.h

5166 sendmail package should be replaceable
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/fgetln.c

5166 sendmail package should be replaceable
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/fparseln.c

5166 sendmail package should be replaceable
207 lines changed: 207 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/mailer.conf

5166 sendmail package should be replaceable
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/mailwrapper.c

5166 sendmail package should be replaceable
167 lines changed: 167 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mailwrapper/pathnames.h

5166 sendmail package should be replaceable
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mailx/names.c

5166 sendmail package should be replaceable
7 lines changed: 0 ins; 6 del; 1 mod; 834 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sendmail/Makefile.cmd

5166 sendmail package should be replaceable
8 lines changed: 8 ins; 0 del; 0 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sendmail/aux/Makefile

5166 sendmail package should be replaceable
7 lines changed: 3 ins; 0 del; 4 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sendmail/aux/mailq.c

5166 sendmail package should be replaceable
1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sendmail/src/Makefile

5166 sendmail package should be replaceable
3 lines changed: 0 ins; 0 del; 3 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/shell/sendmail_include.sh

5166 sendmail package should be replaceable
1 line changed: 0 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/Makefile

5166 sendmail package should be replaceable
1 line changed: 1 ins; 0 del; 0 mod; 800 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man1m/mailwrapper.1m

5166 sendmail package should be replaceable
130 lines changed: 130 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man4/Makefile

5166 sendmail package should be replaceable
1 line changed: 1 ins; 0 del; 0 mod; 293 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/man/man4/mailer.conf.4

5166 sendmail package should be replaceable
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.mf

5166 sendmail package should be replaceable
4 lines changed: 4 ins; 0 del; 0 mod; 1902 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-build-onbld.mf

5166 sendmail package should be replaceable
2 lines changed: 0 ins; 2 del; 0 mod; 232 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/service-network-smtp-sendmail.mf

5166 sendmail package should be replaceable
17 lines changed: 12 ins; 2 del; 3 mod; 230 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-network-mailwrapper.mf

5166 sendmail package should be replaceable
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/hgsetup.sh

5166 sendmail package should be replaceable
3 lines changed: 1 ins; 0 del; 2 mod; 186 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/validate_pkg.py

5166 sendmail package should be replaceable
8 lines changed: 7 ins; 0 del; 1 mod; 890 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.