Print this page
4853 illumos-gate is not lint-clean when built with openssl 1.0
@@ -108,11 +108,10 @@
goto cleanup;
}
/* add all ca certs into the store */
for (i = 0; i < sk_X509_num(cas); i++) {
- /* LINTED pointer cast may result in improper alignment */
ca_cert = sk_X509_value(cas, i);
if (X509_STORE_add_cert(ca_store, ca_cert) == 0) {
pkgerr_add(err, PKGERR_NOMEM, gettext(ERR_MEM));
ret = 1;
goto cleanup;
@@ -172,12 +171,11 @@
xname = X509_get_subject_name(cert);
if (X509_NAME_get_text_by_NID(xname,
NID_commonName, sname,
ATTR_MAX) <= 0) {
(void) strncpy(sname,
- X509_NAME_oneline(xname,
- NULL, 0), ATTR_MAX);
+ X509_NAME_oneline(xname, NULL, 0), ATTR_MAX);
sname[ATTR_MAX - 1] = '\0';
}
return (sname);
}
@@ -203,12 +201,11 @@
xname = X509_get_issuer_name(cert);
if (X509_NAME_get_text_by_NID(xname,
NID_commonName, sname,
ATTR_MAX) <= 0) {
(void) strncpy(sname,
- X509_NAME_oneline(xname,
- NULL, 0), ATTR_MAX);
+ X509_NAME_oneline(xname, NULL, 0), ATTR_MAX);
sname[ATTR_MAX - 1] = '\0';
}
return (sname);
}