Code Review for master2

Prepared by:Super-User (root) on 2012-Aug-31 05:09 +0400 MSK
Workspace:/export/home/git/master2 (at a74b99fd0a8a)
Compare against: bd21e101 (at bd21e101f750)
Summary of changes: 3494 lines changed: 3340 ins; 28 del; 126 mod; 23057 unchg
Patch of changes: master2.patch
Printable review: master2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw bootadm/bootadm.c

botadm patch
79 lines changed: 45 ins; 4 del; 30 mod; 9639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw bootadm/bootadm.h

botadm patch
3 lines changed: 1 ins; 0 del; 2 mod; 311 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw bootadm/bootadm_hyper.c

bug fix
adding functionality and fixing bugs
adding functions to menuadm
menuadm to replace bootadm menu interaction
hypervisor + bug fix
18 lines changed: 12 ins; 0 del; 6 mod; 1249 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/Makefile.util.def

grub patch
15 lines changed: 15 ins; 0 del; 0 mod; 761 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/grub-core/Makefile.core.def

grub patch
10 lines changed: 10 ins; 0 del; 0 mod; 1842 unchg

------ ------ ------ ------ ------ --- New Patch Raw grub/grub-core/commands/illumos_entries.c

grub patch
197 lines changed: 197 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw grub/grub-core/commands/menu_managing.c

grub patch
200 lines changed: 200 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/grub-core/commands/search.c

fixes + mirror
29 lines changed: 23 ins; 0 del; 6 mod; 307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/grub-core/commands/search_wrap.c

fixes + mirror
9 lines changed: 6 ins; 0 del; 3 mod; 212 unchg

------ ------ ------ ------ ------ --- New Patch Raw grub/grub-core/commands/solarislegacy.c

grub patch
213 lines changed: 213 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/grub-core/fs/zfs/zfs.c

grub patch
267 lines changed: 231 ins; 21 del; 15 mod; 3938 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/grub-core/fs/zfs/zfsinfo.c

grub patch
26 lines changed: 18 ins; 0 del; 8 mod; 421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/grub-core/partmap/sun.c

grub patch
7 lines changed: 0 ins; 0 del; 7 mod; 148 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/grub-core/partmap/sunpc.c

grub patch
5 lines changed: 0 ins; 0 del; 5 mod; 146 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/include/grub/search.h

fix mirror
3 lines changed: 0 ins; 0 del; 3 mod; 26 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/include/grub/zfs/dmu.h

feature flags + bug fix
42 lines changed: 41 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/include/grub/zfs/zfs.h

grub patch
6 lines changed: 6 ins; 0 del; 0 mod; 153 unchg

------ ------ ------ ------ ------ --- New Patch Raw grub/util/grub-solarislst2cfg.c

grub patch
274 lines changed: 274 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw grub/util/grub.d/10_illumos.in

fixes
4 lines changed: 4 ins; 0 del; 0 mod; 52 unchg

------ ------ ------ ------ ------ --- New Patch Raw grubadm/error.c

menuadm->grubadm, ba_path->module, various changes, starting adding serial terminal configuring to grubadm
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw grubadm/error.h

menuadm->grubadm, ba_path->module, various changes, starting adding serial terminal configuring to grubadm
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw grubadm/grubadm.1m

license + man
554 lines changed: 554 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw grubadm/grubadm.c

rename
615 lines changed: 615 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw grubadm/grubadm.h

rename
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw grubadm/menu.c

menuadm->grubadm, ba_path->module, various changes, starting adding serial terminal configuring to grubadm
581 lines changed: 581 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw grubadm/menu.h

menuadm->grubadm, ba_path->module, various changes, starting adding serial terminal configuring to grubadm
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw libbe/common/be_utils.c

libbe patch
101 lines changed: 58 ins; 3 del; 40 mod; 3733 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.