Code Review for illumos-gate

Prepared by:david (david) on 2013-Jan-11 07:50 +0000 UTC
Workspace:/home/david/ws/illumos-gate (at b12087b1e018)
Compare against: adbbcfface63b3a71922d5a25d34a2018c0435de (at adbbcfface63)
Summary of changes: 2119 lines changed: 1818 ins; 294 del; 7 mod; 411 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/kstat/Makefile (deleted)

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/kstat/kstat.pl (deleted)

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
245 lines changed: 0 ins; 245 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/stat/Makefile

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
3 lines changed: 0 ins; 2 del; 1 mod; 45 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/stat/kstat/Makefile

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/stat/kstat/kstat.c

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
1470 lines changed: 1470 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/stat/kstat/kstat.h

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
269 lines changed: 269 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/kstat.1m

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
24 lines changed: 18 ins; 0 del; 6 mod; 366 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.