Code Review for illumos-gate

Prepared by:david (david) on 2012-Nov-30 19:01 +0000 UTC
Workspace:/home/david/ws/illumos-gate (at 3a4b0cff7d59)
Compare against: 71dbfc287ce623fa58f67b024d14ef6924fa1b2a (at 71dbfc287ce6)
Summary of changes: 2064 lines changed: 1758 ins; 296 del; 10 mod; 406 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/kstat/Makefile (deleted)

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/kstat/kstat.pl (deleted)

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
245 lines changed: 0 ins; 245 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/stat/Makefile

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
3 lines changed: 0 ins; 2 del; 1 mod; 45 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/stat/kstat/Makefile

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/stat/kstat/kstat.c

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
1419 lines changed: 1419 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/stat/kstat/kstat.h

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
261 lines changed: 261 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1m/kstat.1m

749 "/usr/bin/kstat" should be rewritten in C
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Brendan Gregg <brendan.gregg@joyent.com>
28 lines changed: 17 ins; 2 del; 9 mod; 361 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.