Code Review for illumos-dccp

Prepared by:david (david) on 2012-Aug-08 12:42 +0000 UTC
Workspace:/home/david/ws/illumos-dccp (at 32c7a88f0fc6)
Compare against: 6a3e8e8695d5c7d1d18c6800d676990d7f61a2a4 (at 6a3e8e8695d5)
Summary of changes: 9095 lines changed: 9059 ins; 9 del; 27 mod; 104357 unchg
Patch of changes: illumos-dccp.patch
Printable review: illumos-dccp.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/packaging

dccp: finish move headers, cleanup dccp states
1 line changed: 1 ins; 0 del; 0 mod; 958 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/etc/sock2path.d/system%2Fkernel

dccp: lint fixes, dccp_conn_create_v6
2 lines changed: 2 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/netstat/netstat.c

dccp: complete netstack
154 lines changed: 153 ins; 0 del; 1 mod; 6454 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/ipadm/ipadm.c

dccp: properties
2 lines changed: 0 ins; 0 del; 2 mod; 2219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/Makefile

dccp: snoop, build system fixes
2 lines changed: 0 ins; 0 del; 2 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop.h

dccp: snoop, build system fixes
2 lines changed: 2 ins; 0 del; 0 mod; 355 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_dccp.c

dccp: snoop, build system fixes
433 lines changed: 433 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_filter.c

dccp: options and features
6 lines changed: 6 ins; 0 del; 0 mod; 2843 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_ip.c

dccp: snoop, build system fixes
9 lines changed: 9 ins; 0 del; 0 mod; 1489 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_ipsec.c

dccp: snoop, build system fixes
4 lines changed: 4 ins; 0 del; 0 mod; 243 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_pf.c

dccp: options and features
15 lines changed: 15 ins; 0 del; 0 mod; 1662 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_rport.c

dccp: options and features
2 lines changed: 1 ins; 0 del; 1 mod; 451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/devfsadm/misc_link.c

dccp: fix setsockopt bug
2 lines changed: 0 ins; 0 del; 2 mod; 702 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/genunix.c

dccp: build fixes, mdb (vfs sonode missing)
3 lines changed: 2 ins; 0 del; 1 mod; 4610 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/net.c

dccp: build fixes, mdb (vfs sonode missing)
113 lines changed: 113 ins; 0 del; 0 mod; 1642 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/net.h

dccp: build fixes, mdb (vfs sonode missing)
2 lines changed: 2 ins; 0 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/ip/ip.c

dccp: conn_t
12 lines changed: 11 ins; 0 del; 1 mod; 3629 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/Makefile.com

dccp: basic dtrace
5 lines changed: 5 ins; 0 del; 0 mod; 235 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdtrace/common/dccp.d.in

dccp: basic dtrace
181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdtrace/common/dccp.sed.in

dccp: basic dtrace
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/dt_open.c

dccp: basic dtrace
4 lines changed: 2 ins; 0 del; 2 mod; 1407 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/ip.d.in

dccp: sock upcalls
2 lines changed: 2 ins; 0 del; 0 mod; 374 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdtrace/common/ip.sed.in

dccp: sock upcalls
1 line changed: 1 ins; 0 del; 0 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipadm/common/ipadm_prop.c

dccp: properties
32 lines changed: 30 ins; 0 del; 2 mod; 1938 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-dtrace.mf

dccp: basic dtrace
1 line changed: 1 ins; 0 del; 0 mod; 655 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf

dccp: small build fix
5 lines changed: 5 ins; 0 del; 0 mod; 2137 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-kernel.mf

dccp: manifest
14 lines changed: 14 ins; 0 del; 0 mod; 911 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

dccp: starting module template
9 lines changed: 8 ins; 0 del; 1 mod; 2017 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.rules

dccp: starting module template
7 lines changed: 7 ins; 0 del; 0 mod; 2671 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/dtrace/sdt_subr.c

dccp: basic dtrace
44 lines changed: 44 ins; 0 del; 0 mod; 1191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/Makefile

dccp: finish moving headers
2 lines changed: 1 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/dccp.h

dccp: finish moving headers
218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/dccp/dccp.c

dccp: starting module template
1244 lines changed: 1244 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp.conf

dccp: starting module template
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp6.conf

dccp: clean up
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp6ddi.c

dccp: clean up
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_bind.c

dccp: bind function
709 lines changed: 709 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_features.c

dccp: options and features
99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_input.c

dccp: starting module template
927 lines changed: 927 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_misc.c

dccp: add dccp_misc.c
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_opt_data.c

dccp: starting with options
153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/dccp/dccp_options.c

dccp: split options and feature functions
295 lines changed: 295 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/dccp/dccp_output.c

dccp: clean up
808 lines changed: 808 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_socket.c

dccp: starting module template
694 lines changed: 694 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/dccp/dccp_stats.c

dccp: MIB-II
583 lines changed: 583 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_timers.c

dccp: bring in timers
241 lines changed: 241 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_tpi.c

dccp: clean up
310 lines changed: 310 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccp_tunables.c

dccp: starting module template
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp/dccpddi.c

dccp: starting module template
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/dccp_impl.h

dccp: move headers into inet dir, like other protocols
332 lines changed: 332 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp_ip.h

dccp: move headers into inet dir, like other protocols
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp_stack.h

dccp: move headers into inet dir, like other protocols
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/inet/dccp_stats.h

dccp: move headers into inet dir, like other protocols
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip.h

dccp: starting module template
11 lines changed: 11 ins; 0 del; 0 mod; 3761 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip.c

dccp: starting module template
12 lines changed: 12 ins; 0 del; 0 mod; 15259 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_if.c

dccp: properties
6 lines changed: 6 ins; 0 del; 0 mod; 19162 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_input.c

dccp: ips_ipcl_dccp_fanout
67 lines changed: 67 ins; 0 del; 0 mod; 3136 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_output.c

dccp: reset packet
6 lines changed: 6 ins; 0 del; 0 mod; 2564 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ipclassifier.c

dccp: conn_t
284 lines changed: 284 ins; 0 del; 0 mod; 2724 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip_impl.h

dccp: reset packet
8 lines changed: 8 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip_stack.h

dccp: ips_ipcl_dccp_fanout
4 lines changed: 4 ins; 0 del; 0 mod; 449 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipclassifier.h

dccp: conn_t
18 lines changed: 17 ins; 0 del; 1 mod; 736 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/kstatcom.h

dccp: stats
6 lines changed: 6 ins; 0 del; 0 mod; 477 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/mib2.h

dccp: MIB-II
121 lines changed: 120 ins; 0 del; 1 mod; 1793 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/sctp/sctp_impl.h

sctp: align to cache line
3 lines changed: 3 ins; 0 del; 0 mod; 1208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp.c

tcp: conn_mlp_type will be set later in tcp_init_values
1 line changed: 0 ins; 1 del; 0 mod; 4473 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_opt_data.c

tcp: maybe related to 721fffe3
2 lines changed: 2 ins; 0 del; 0 mod; 1089 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp/tcp_socket.c

tcp: maybe related to 721fffe3
8 lines changed: 5 ins; 0 del; 3 mod; 1169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_impl.h

tcp: maybe related to 721fffe3
5 lines changed: 0 ins; 5 del; 0 mod; 705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tcp_stats.h

tcp: spelling
1 line changed: 0 ins; 0 del; 1 mod; 250 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tunables.c

dccp: starting module template
7 lines changed: 7 ins; 0 del; 0 mod; 456 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/tunables.h

dccp: starting module template
1 line changed: 1 ins; 0 del; 0 mod; 187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/netinet/Makefile

dccp: snoop, build system fixes
7 lines changed: 0 ins; 3 del; 4 mod; 48 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/netinet/dccp.h

dccp: starting module template
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/netinet/in.h

dccp: starting module template
1 line changed: 1 ins; 0 del; 0 mod; 1319 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/netstack.h

dccp: starting module template
4 lines changed: 3 ins; 0 del; 1 mod; 276 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sdt.h

dccp: connect
27 lines changed: 27 ins; 0 del; 0 mod; 420 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/Makefile.intel.shared

dccp: starting module template
2 lines changed: 2 ins; 0 del; 0 mod; 740 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/dccp/Makefile

dccp: starting with options
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/dccp6/Makefile

dccp: clean up
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ip/ip.global-objs.debug64

dccp: starting module template
27 lines changed: 27 ins; 0 del; 0 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ip/ip.global-objs.obj64

dccp: starting module template
27 lines changed: 27 ins; 0 del; 0 mod; 318 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.