Code Review for illumos-gate

Prepared by:david (david) on 2013-Jul-11 12:26 +0000 UTC
Workspace:/home/david/ws/illumos-gate (at c7e4352f17c3)
Compare against: HEAD^ (at be468fc6d726)
Summary of changes: 1400 lines changed: 1233 ins; 15 del; 152 mod; 9466 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/locale_iso.h 

2964 need POSIX 2008 locale object support
24 lines changed: 22 ins; 2 del; 0 mod; 124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/langinfo.h 

2964 need POSIX 2008 locale object support
11 lines changed: 7 ins; 2 del; 2 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/amd64/Makefile 

2964 need POSIX 2008 locale object support
2 lines changed: 1 ins; 0 del; 1 mod; 1222 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386/Makefile.com 

2964 need POSIX 2008 locale object support
2 lines changed: 1 ins; 0 del; 1 mod; 1294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/collate.c 

2964 need POSIX 2008 locale object support
32 lines changed: 32 ins; 0 del; 0 mod; 637 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/collate.h 

2964 need POSIX 2008 locale object support
10 lines changed: 10 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmessages.c 

2964 need POSIX 2008 locale object support
58 lines changed: 43 ins; 0 del; 15 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmessages.h 

2964 need POSIX 2008 locale object support
14 lines changed: 13 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmonetary.c 

2964 need POSIX 2008 locale object support
70 lines changed: 51 ins; 1 del; 18 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lmonetary.h 

2964 need POSIX 2008 locale object support
14 lines changed: 13 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lnumeric.c 

2964 need POSIX 2008 locale object support
72 lines changed: 48 ins; 6 del; 18 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/lnumeric.h 

2964 need POSIX 2008 locale object support
14 lines changed: 13 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/localeconv.c 

2964 need POSIX 2008 locale object support
26 lines changed: 12 ins; 2 del; 12 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/mblocal.h 

2964 need POSIX 2008 locale object support
27 lines changed: 26 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/nl_langinfo.c 

2964 need POSIX 2008 locale object support
16 lines changed: 11 ins; 0 del; 5 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/none.c 

2964 need POSIX 2008 locale object support
38 lines changed: 30 ins; 0 del; 8 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setlocale.c 

2964 need POSIX 2008 locale object support
13 lines changed: 11 ins; 1 del; 1 mod; 327 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setlocale.h 

2964 need POSIX 2008 locale object support
1 line changed: 1 ins; 0 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/setrunelocale.c 

2964 need POSIX 2008 locale object support
64 lines changed: 37 ins; 0 del; 27 mod; 225 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/strftime.c 

2964 need POSIX 2008 locale object support
58 lines changed: 38 ins; 1 del; 19 mod; 507 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/strptime.c 

2964 need POSIX 2008 locale object support
50 lines changed: 37 ins; 0 del; 13 mod; 542 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/timelocal.c 

2964 need POSIX 2008 locale object support
49 lines changed: 43 ins; 0 del; 6 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/timelocal.h 

2964 need POSIX 2008 locale object support
13 lines changed: 12 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/wcwidth.c 

2964 need POSIX 2008 locale object support
7 lines changed: 7 ins; 0 del; 0 mod; 78 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/locale/xlocale.c 

2964 need POSIX 2008 locale object support
363 lines changed: 363 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libc/port/locale/xlocale_private.h 

2964 need POSIX 2008 locale object support
241 lines changed: 241 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers 

2964 need POSIX 2008 locale object support
11 lines changed: 11 ins; 0 del; 0 mod; 3134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/os-tests/tests/Makefile 

2964 need POSIX 2008 locale object support
1 line changed: 0 ins; 0 del; 1 mod; 17 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/os-tests/tests/xlocale/Makefile 

2964 need POSIX 2008 locale object support
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/os-tests/tests/xlocale/xlocale_test.c 

2964 need POSIX 2008 locale object support
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.